xen/mce: don't issue error message for failed /dev/mcelog registration
Subsystems (3)
Juergen Gross
maintainerPATCH v3 1/1 xen/mce: don't issue error message for failed /dev/mcelog registration
When running under Xen as dom0 /dev/mcelog is being registered by Xen instead of the normal mcelog driver. Avoid an error message being issued by the mcelog driver in this case. Instead issue an informative message that Xen has registered the device.
--- arch/x86/kernel/cpu/mcheck/dev-mcelog.c | 7 ++++++- drivers/xen/mcelog.c | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/mcheck/dev-mcelog.c +6 -1
@@ -388,7 +388,12 @@ static __init int dev_mcelog_init_device(void)/* register character device /dev/mcelog */ err =misc_register (&mce_chrdev_device);if (err) { -pr_err ("Unable to init device /dev/mcelog (rc: %d)\n" , err); +if (err == -EBUSY ) +/* Xen dom0 might have registered the device already. */ +pr_info ("Unable to init device /dev/mcelog, already registered" ); +else +pr_err ("Unable to init device /dev/mcelog (rc: %d)\n" , + err);return err; }mce_register_decode_chain (&dev_mcelog_nb);
drivers/xen/mcelog.c +2 -0
@@ -408,6 +408,8 @@ static int __init xen_late_init_mcelog(void)if (ret) goto deregister; +pr_info ("/dev/mcelog registered by Xen\n" ); +return 0 ; deregister:
Signature · 1 line
2.12.3
Quoted 10 lines · Juergen Gross
When running under Xen as dom0
/dev/mcelogis being registered by Xen instead of the normal mcelog driver. Avoid an error message being issued by the mcelog driver in this case. Instead issue an informative message that Xen has registered the device.Signed-off-by Juergen Gross <[email protected]>--- arch/x86/kernel/cpu/mcheck/dev-mcelog.c | 7 ++++++- drivers/xen/mcelog.c | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-)
Applied, thanks.
Signature · 4 lines
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.Quoted 10 lines · Juergen Gross
When running under Xen as dom0
/dev/mcelogis being registered by Xen instead of the normal mcelog driver. Avoid an error message being issued by the mcelog driver in this case. Instead issue an informative message that Xen has registered the device.Signed-off-by Juergen Gross <[email protected]>--- arch/x86/kernel/cpu/mcheck/dev-mcelog.c | 7 ++++++- drivers/xen/mcelog.c | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-)
Applied, thanks.
Signature · 9 lines
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-develtip-bot for Juergen Gross
merge bot[tip:ras/core] x86/MCE, xen/mcelog: Make /dev/mcelog registration messages more precise
In reply to Juergen Grossx86/MCE, xen/mcelog: Make /dev/mcelog registration messages more precise
Commit-ID: b867059018a5254cca14450eefb6fb8effa0f6dd Gitweb: http://git.kernel.org/tip/b867059018a5254cca14450eefb6fb8effa0f6dd Author: Juergen Gross <[email protected]> AuthorDate: Tue, 20 Jun 2017 23:16:37 +0200 Committer: Thomas Gleixner <[email protected]> CommitDate: Tue, 20 Jun 2017 23:25:19 +0200
x86/MCE, xen/mcelog: Make /dev/mcelog registration messages more precise
When running under Xen as dom0, /dev/mcelog is being provided by Xen instead of the normal mcelog character device of the MCE core. Convert an error message being issued by the MCE core in this case to an informative message that Xen has registered the device.
--- arch/x86/kernel/cpu/mcheck/dev-mcelog.c | 8 +++++++- drivers/xen/mcelog.c | 2 ++ 2 files changed, 9 insertions(+), 1 deletion(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-edac" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
arch/x86/kernel/cpu/mcheck/dev-mcelog.c +7 -1
@@ -415,9 +415,15 @@ static __init int dev_mcelog_init_device(void)/* register character device /dev/mcelog */ err =misc_register (&mce_chrdev_device);if (err) { -pr_err ("Unable to init device /dev/mcelog (rc: %d)\n" , err); +if (err == -EBUSY ) +/* Xen dom0 might have registered the device already. */ +pr_info ("Unable to init device /dev/mcelog, already registered" ); +else +pr_err ("Unable to init device /dev/mcelog (rc: %d)\n" , err); +return err; } +mce_register_decode_chain (&dev_mcelog_nb);return 0 ; }
drivers/xen/mcelog.c +2 -0
@@ -408,6 +408,8 @@ static int __init xen_late_init_mcelog(void)if (ret) goto deregister; +pr_info ("/dev/mcelog registered by Xen\n" ); +return 0 ; deregister: