Skip to contentSkip to conversation

x86/fpu: Get rid of CONFIG_AS_FXSAVEQ

PATCH In review Borislav Petkov 3 participants 3 messages Jan 17, 2019 – Jan 22, 2019 x86

lore
Share & tools
lore

Borislav Petkov

author maintainer
#0 lore raw

PATCH 1/1 x86/fpu: Get rid of CONFIG_AS_FXSAVEQ

One more cleanup resulting from me staring at bigeasy's FPU patchset. I've tested building this in an old debian guest which has binutils 2.22 and gcc 4.6, the last being the oldest gcc we support.

echo "fxsaveq (%rax)" | gcc -c -x assembler -o /tmp/t.o -

with gas 2.20 works too, 2.20 being the minimum binutils version we require in Documentation/process/changes.rst

--
From: Borislav Petkov <[email protected]>

This was a "workaround" to probe for binutils which could generate FXSAVEQ, apparently gas with min version 2.16. In the meantime, minimal required gas version is 2.20 so all those workarounds for older binutils can be dropped.

Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Sebastian Andrzej Siewior <[email protected]>
Cc Andy Lutomirski <[email protected]>
---
 arch/x86/Makefile                   |  1 -
 arch/x86/include/asm/fpu/internal.h | 50 ++++-------------------------
 2 files changed, 6 insertions(+), 45 deletions(-)
arch/x86/Makefile +0 -1
index 9c5a67d1b9c1..76bc4dc03d5e 100644
@@ -187,7 +187,6 @@ cfi-sigframe := $(call as-instr,.cfi_startproc\n.cfi_signal_frame\n.cfi_endproc,
 cfi-sections := $(call as-instr,.cfi_sections .debug_frame,-DCONFIG_AS_CFI_SECTIONS=1)
 
 # does binutils support specific instructions?
-asinstr := $(call as-instr,fxsaveq (%rax),-DCONFIG_AS_FXSAVEQ=1)
 asinstr += $(call as-instr,pshufb %xmm0$(comma)%xmm0,-DCONFIG_AS_SSSE3=1)
 avx_instr := $(call as-instr,vxorps %ymm0$(comma)%ymm1$(comma)%ymm2,-DCONFIG_AS_AVX=1)
 avx2_instr :=$(call as-instr,vpbroadcastb %xmm0$(comma)%ymm1,-DCONFIG_AS_AVX2=1)
arch/x86/include/asm/fpu/internal.h +6 -44

77 lines not on this page · raw message

Signature · 7 lines
2.19.1

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Borislav Petkov

From: Borislav Petkov <[email protected]>

This was a "workaround" to probe for binutils which could generate FXSAVEQ, apparently gas with min version 2.16. In the meantime, minimal required gas version is 2.20 so all those workarounds for older binutils can be dropped.

indeed.

Quoted 6 lines
Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Sebastian Andrzej Siewior <[email protected]>
Cc Andy Lutomirski <[email protected]>

Sebastian

#2 lore raw
In reply to Borislav Petkov
x86/fpu: Get rid of CONFIG_AS_FXSAVEQ
Commit-ID:  bae54dc4f353653bbd3e3081754adad05da1d4dd
Gitweb:     https://git.kernel.org/tip/bae54dc4f353653bbd3e3081754adad05da1d4dd
Author:     Borislav Petkov <[email protected]>
AuthorDate: Fri, 18 Jan 2019 00:05:40 +0100
Committer:  Borislav Petkov <[email protected]>
CommitDate: Tue, 22 Jan 2019 14:16:39 +0100

x86/fpu: Get rid of CONFIG_AS_FXSAVEQ

This was a "workaround" to probe for binutils which could generate FXSAVEQ, apparently gas with min version 2.16. In the meantime, minimal required gas version is 2.20 so all those workarounds for older binutils can be dropped.

---
 arch/x86/Makefile                   |  1 -
 arch/x86/include/asm/fpu/internal.h | 50 +++++--------------------------------
 2 files changed, 6 insertions(+), 45 deletions(-)
arch/x86/Makefile +0 -1
index 9c5a67d1b9c1..76bc4dc03d5e 100644
@@ -187,7 +187,6 @@ cfi-sigframe := $(call as-instr,.cfi_startproc\n.cfi_signal_frame\n.cfi_endproc,
 cfi-sections := $(call as-instr,.cfi_sections .debug_frame,-DCONFIG_AS_CFI_SECTIONS=1)
 
 # does binutils support specific instructions?
-asinstr := $(call as-instr,fxsaveq (%rax),-DCONFIG_AS_FXSAVEQ=1)
 asinstr += $(call as-instr,pshufb %xmm0$(comma)%xmm0,-DCONFIG_AS_SSSE3=1)
 avx_instr := $(call as-instr,vxorps %ymm0$(comma)%ymm1$(comma)%ymm2,-DCONFIG_AS_AVX=1)
 avx2_instr :=$(call as-instr,vpbroadcastb %xmm0$(comma)%ymm1,-DCONFIG_AS_AVX2=1)
arch/x86/include/asm/fpu/internal.h +6 -44

77 lines not on this page · raw message