perf browser ui segfault on 'a' for annotate
PATCH 1/1 perf browser ui segfault on 'a' for annotate
Hi Arnaldo,
There a typo in util/ui/browsers/hists.c that leads to a segfault when you press the 'a' key on a non-resolved symbol (plain hex address).
This is fixed by the patch below.
Thanks,
Frederik
tools/perf/util/ui/browsers/hists.c +1 -1
@@ -773,7 +773,7 @@ int hists__browse(struct hists *self, const char *helpline, const char *ev_name)switch (key) {case 'a' : -if (browser->selection->map ==NULL && +if (browser->selection->map ==NULL || browser->selection->map->dso->annotate_warned)continue ; goto do_annotate;
Arnaldo Carvalho de Melo
AppliedEm Thu, Sep 23, 2010 at 10:19:01PM +0200, Frederik Deweerdt escreveu:
Quoted 6 lines
Hi Arnaldo,
There a typo in
util/ui/browsers/hists.cthat leads to a segfault when you press the 'a' key on a non-resolved symbol (plain hex address).This is fixed by the patch below.
Thanks, applied!
- Arnaldo
[tip:perf/core] perf ui hist browser: Fix segfault on 'a' for annotate
In reply to Frederik DeweerdtCommit-ID: c569d3326bca6774f6c23f1dc91acad5400b6409 Gitweb: http://git.kernel.org/tip/c569d3326bca6774f6c23f1dc91acad5400b6409 Author: Frederik Deweerdt <[email protected]> AuthorDate: Thu, 23 Sep 2010 22:19:01 +0200 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 4 Oct 2010 12:08:37 -0300
perf ui hist browser: Fix segfault on 'a' for annotate
There a typo in util/ui/browsers/hists.c that leads to a segfault when you press the 'a' key on a non-resolved symbol (plain hex address).
LKML-Reference: <20100923201901.GE31726@gambetta>
--- tools/perf/util/ui/browsers/hists.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
tools/perf/util/ui/browsers/hists.c +1 -1
@@ -773,7 +773,7 @@ int hists__browse(struct hists *self, const char *helpline, const char *ev_name)switch (key) {case 'a' : -if (browser->selection->map ==NULL && +if (browser->selection->map ==NULL || browser->selection->map->dso->annotate_warned)continue ; goto do_annotate;