Skip to contentSkip to conversation

perf: fix comments in PERF_MEM_LVL bitmask

PATCH New Stephane Eranian 2 participants 2 messages Apr 5, 2013 – Apr 8, 2013 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf: fix comments in PERF_MEM_LVL bitmask

This small patch fixes a mistake in the comments for the PERF_MEM_LVL_* events. The L2, L3 bits simply represent cache levels, not hits or misses. That is encoded in PERF_MEM_LVL_MISS/PERF_MEM_LVL_HIT.

---

include/uapi/linux/perf_event.h +2 -2
index 964a450..fb104e5 100644
@@ -645,8 +645,8 @@ union perf_mem_data_src {
 #define PERF_MEM_LVL_MISS	0x04  /* miss level  */
 #define PERF_MEM_LVL_L1		0x08  /* L1 */
 #define PERF_MEM_LVL_LFB	0x10  /* Line Fill Buffer */
-#define PERF_MEM_LVL_L2		0x20  /* L2 hit */
-#define PERF_MEM_LVL_L3		0x40  /* L3 hit */
+#define PERF_MEM_LVL_L2		0x20  /* L2 */
+#define PERF_MEM_LVL_L3		0x40  /* L3 */
 #define PERF_MEM_LVL_LOC_RAM	0x80  /* Local DRAM */
 #define PERF_MEM_LVL_REM_RAM1	0x100 /* Remote DRAM (1 hop) */
 #define PERF_MEM_LVL_REM_RAM2	0x200 /* Remote DRAM (2 hops) */
#1 lore raw

[tip:perf/core] perf: Fix comments in PERF_MEM_LVL bitmask

perf: Fix comments in PERF_MEM_LVL bitmask
Commit-ID:  cc2f5a8adbc7ab1fdb7d9bcf4ea9838c73e82dfe
Gitweb:     http://git.kernel.org/tip/cc2f5a8adbc7ab1fdb7d9bcf4ea9838c73e82dfe
Author:     Stephane Eranian <[email protected]>
AuthorDate: Fri, 5 Apr 2013 16:49:41 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 8 Apr 2013 13:54:24 +0200

perf: Fix comments in PERF_MEM_LVL bitmask

This small patch fixes a mistake in the comments for the PERF_MEM_LVL_* events. The L2, L3 bits simply represent cache levels, not hits or misses. That is encoded in PERF_MEM_LVL_MISS/PERF_MEM_LVL_HIT.

---
 include/uapi/linux/perf_event.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/uapi/linux/perf_event.h +2 -2
index 964a450..fb104e5 100644
@@ -645,8 +645,8 @@ union perf_mem_data_src {
 #define PERF_MEM_LVL_MISS	0x04  /* miss level  */
 #define PERF_MEM_LVL_L1		0x08  /* L1 */
 #define PERF_MEM_LVL_LFB	0x10  /* Line Fill Buffer */
-#define PERF_MEM_LVL_L2		0x20  /* L2 hit */
-#define PERF_MEM_LVL_L3		0x40  /* L3 hit */
+#define PERF_MEM_LVL_L2		0x20  /* L2 */
+#define PERF_MEM_LVL_L3		0x40  /* L3 */
 #define PERF_MEM_LVL_LOC_RAM	0x80  /* Local DRAM */
 #define PERF_MEM_LVL_REM_RAM1	0x100 /* Remote DRAM (1 hop) */
 #define PERF_MEM_LVL_REM_RAM2	0x200 /* Remote DRAM (2 hops) */