Skip to contentSkip to conversation

sched, __wake_up_sync_key: Fix nr_exclusive tasks which lead to WF_SYNC clearing

PATCH In review Kirill Tkhai 3 participants 3 messages Jul 4, 2013 – Jul 12, 2013 Scheduler

lore
Share & tools
lore

Kirill Tkhai

author
#0 lore raw

PATCH 1/1 sched, __wake_up_sync_key: Fix nr_exclusive tasks which lead to WF_SYNC clearing

The only one task can replace waker.

Signed-off-by Kirill Tkhai <[email protected]>
CC Steven Rostedt <[email protected]>
CC Ingo Molnar <[email protected]>
CC Peter Zijlstra <[email protected]>
---
 kernel/sched/core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/sched/core.c +1 -1
index 9d06ad6..4ff7404 100644
@@ -2658,7 +2658,7 @@ void __wake_up_sync_key(wait_queue_head_t *q, unsigned int mode,
 	if (unlikely(!q))
 		return;
 
-	if (unlikely(!nr_exclusive))
+	if (unlikely(nr_exclusive != 1))
 		wake_flags = 0;
 
 	spin_lock_irqsave(&q->lock, flags);
maintainer
#1 lore raw
Quoted 1 line · Kirill Tkhai

The only one task can replace waker.

Fair enough.. thanks!

merge bot
#2 lore raw

[tip:sched/core] sched/__wake_up_sync_key(): Fix nr_exclusive tasks which lead to WF_SYNC clearing

In reply to Kirill Tkhai
sched/__wake_up_sync_key(): Fix nr_exclusive tasks which lead to WF_SYNC clearing
Commit-ID:  cedce3e730833d26a37826a96e1905b6ef387df9
Gitweb:     http://git.kernel.org/tip/cedce3e730833d26a37826a96e1905b6ef387df9
Author:     Kirill Tkhai <[email protected]>
AuthorDate: Thu, 4 Jul 2013 22:48:20 +0400
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 12 Jul 2013 13:54:03 +0200

sched/__wake_up_sync_key(): Fix nr_exclusive tasks which lead to WF_SYNC clearing

Only one task can replace the waker.

Signed-off-by Kirill Tkhai <[email protected]>
CC Steven Rostedt <[email protected]>
Signed-off-by Peter Zijlstra <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Ingo Molnar <[email protected]>
---
 kernel/sched/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/core.c +1 -1
index 0d8eb45..f737871 100644
@@ -2660,7 +2660,7 @@ void __wake_up_sync_key(wait_queue_head_t *q, unsigned int mode,
 	if (unlikely(!q))
 		return;
 
-	if (unlikely(!nr_exclusive))
+	if (unlikely(nr_exclusive != 1))
 		wake_flags = 0;
 
 	spin_lock_irqsave(&q->lock, flags);