Skip to contentSkip to conversation

timers: Remove duplicate setting of new_base in __mod_timer()

PATCH In review Simon Horman 1 participant 2 messages Dec 17, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 timers: Remove duplicate setting of new_base in __mod_timer()

new_base is set using per_cpu(tvec_bases, cpu) after selecting the desired value of cpu immediately below so this line is a unnecessary.

kernel/timer.c +0 -2
Index: linux-2.6/kernel/timer.c
===================================================================
@@ -656,8 +656,6 @@ __mod_timer(struct timer_list *timer, un
 
 	debug_activate(timer, expires);
 
-	new_base = __get_cpu_var(tvec_bases);
-
 	cpu = smp_processor_id();
 
 #if defined(CONFIG_NO_HZ) && defined(CONFIG_SMP)
#1 lore raw
Commit-ID:  cf1e367ee84e02ac349ad0858eb65e8a6a511c8b
Gitweb:     http://git.kernel.org/tip/cf1e367ee84e02ac349ad0858eb65e8a6a511c8b
Author:     Simon Horman <[email protected]>
AuthorDate: Thu, 17 Dec 2009 11:15:42 +1100
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Thu, 17 Dec 2009 01:30:49 +0100

timers: Remove duplicate setting of new_base in __mod_timer()

new_base is set using per_cpu(tvec_bases, cpu) after selecting the desired value of cpu immediately below so this line is a unnecessary.

LKML-Reference: <[email protected]>

---
 kernel/timer.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/timer.c +0 -2
index 5db5a8d..15533b7 100644
@@ -656,8 +656,6 @@ __mod_timer(struct timer_list *timer, unsigned long expires,
 
 	debug_activate(timer, expires);
 
-	new_base = __get_cpu_var(tvec_bases);
-
 	cpu = smp_processor_id();
 
 #if defined(CONFIG_NO_HZ) && defined(CONFIG_SMP)