perf stat: flip around ':k' and ':u' flags
Commit-ID: d3f4b3855ba87caff8f35e738c7e7e3bad0a6ab1 Gitweb: http://git.kernel.org/tip/d3f4b3855ba87caff8f35e738c7e7e3bad0a6ab1 Author: Ingo Molnar <[email protected]> AuthorDate: Mon, 25 May 2009 14:40:01 +0200 Committer: Ingo Molnar <[email protected]> CommitDate: Mon, 25 May 2009 14:40:01 +0200
perf stat: flip around ':k' and ':u' flags
This output:
$ perf stat -e 0:1:k -e 0:1:u ./hello
Performance counter stats for './hello':
140131 instructions (events)
1906968 instructions (events)Is quite confusing - as :k means "user instructions", :u means "kernel instructions".
Flip them around - as the 'exclude' property is not intuitive in the flag naming.
Cc: Peter Zijlstra <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Corey Ashford <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: John Kacur <[email protected]>
Cc: Mike Galbraith <[email protected]>
LKML-Reference: <new-submission>
Signed-off-by Ingo Molnar <[email protected]>
--- Documentation/perf_counter/builtin-stat.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Documentation/perf_counter/builtin-stat.c +2 -2
@@ -266,9 +266,9 @@ static __u64 match_event_symbols(char *str)switch (sscanf (str,"%d:%llu:%2s" , &type, &id, mask_str)) {case 3 : -if (strchr (mask_str,'u' )) - event_mask[nr_counters] |=EVENT_MASK_USER ;if (strchr (mask_str,'k' )) + event_mask[nr_counters] |=EVENT_MASK_USER ; +if (strchr (mask_str,'u' )) event_mask[nr_counters] |=EVENT_MASK_KERNEL ;case 2 :return EID (type, id);