Skip to contentSkip to conversation

x86: perf_counter fix L1-data-Cache-Store-Referencees for AMD

PATCH Superseded Jaswinder Singh Rajput 2 participants 5 messages Jun 18, 2009 – Jun 21, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: perf_counter fix L1-data-Cache-Store-Referencees for AMD

Fix AMD event for Data Cache Refills from System.

By this patch :

./tools/perf/perf stat -e l1d -e l1d-misses -e l1d-write -e l1d-prefetch -e l1d-prefetch-miss -e l1i -e l1i-misses -e l1i-prefetch -e l2 -e l2-misses -e l2-write -e dtlb -e dtlb-misses -e itlb -e itlb-misses -e bpu -e bpu-misses ls /dev/ > /dev/null

Performance counter stats for 'ls /dev/':

        2499484  L1-data-Cache-Load-Referencees  (scaled from 3.97%)
          70347  L1-data-Cache-Load-Misses  (scaled from 7.30%)
           9360  L1-data-Cache-Store-Referencees  (scaled from 8.64%)
          32804  L1-data-Cache-Prefetch-Referencees  (scaled from 17.72%)
           7693  L1-data-Cache-Prefetch-Misses  (scaled from 22.97%)
        2180945  L1-instruction-Cache-Load-Referencees  (scaled from 28.48%)
          14518  L1-instruction-Cache-Load-Misses  (scaled from 35.00%)
           2405  L1-instruction-Cache-Prefetch-Referencees  (scaled from 34.89%)
          71387  L2-Cache-Load-Referencees  (scaled from 34.94%)
          18732  L2-Cache-Load-Misses  (scaled from 34.92%)
          79918  L2-Cache-Store-Referencees  (scaled from 36.02%)
        1295294  Data-TLB-Cache-Load-Referencees  (scaled from 35.99%)
          30896  Data-TLB-Cache-Load-Misses  (scaled from 33.36%)
        1222030  Instruction-TLB-Cache-Load-Referencees  (scaled from 29.46%)
            357  Instruction-TLB-Cache-Load-Misses  (scaled from 20.46%)
         530888  Branch-Cache-Load-Referencees  (scaled from 11.48%)
           8638  Branch-Cache-Load-Misses  (scaled from 5.09%)
    0.011295149  seconds time elapsed.

Earlier it always shows value 0.

---
 arch/x86/kernel/cpu/perf_counter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/perf_counter.c +1 -1
index ce1ae3f..37facc5 100644
@@ -401,7 +401,7 @@ static const u64 amd_hw_cache_event_ids
 		[ C(RESULT_MISS)   ] = 0x0041, /* Data Cache Misses          */
 	},
 	[ C(OP_WRITE) ] = {
-		[ C(RESULT_ACCESS) ] = 0x0042, /* Data Cache Refills from L2 */
+		[ C(RESULT_ACCESS) ] = 0x0142, /* Data Cache Refills :system */
 		[ C(RESULT_MISS)   ] = 0,
 	},
 	[ C(OP_PREFETCH) ] = {
Signature · 1 line
1.6.0.6
#1 lore raw

PATCH RESEND 1/1 x86: perf_counter fix L1-data-Cache-Store-Referencees for AMD

Fix AMD's Data Cache Refills from System event.

By this patch :

./tools/perf/perf stat -e l1d -e l1d-misses -e l1d-write -e l1d-prefetch -e l1d-prefetch-miss -e l1i -e l1i-misses -e l1i-prefetch -e l2 -e l2-misses -e l2-write -e dtlb -e dtlb-misses -e itlb -e itlb-misses -e bpu -e bpu-misses ls /dev/ > /dev/null

Performance counter stats for 'ls /dev/':

        2499484  L1-data-Cache-Load-Referencees  (scaled from 3.97%)
          70347  L1-data-Cache-Load-Misses  (scaled from 7.30%)
           9360  L1-data-Cache-Store-Referencees  (scaled from 8.64%)
          32804  L1-data-Cache-Prefetch-Referencees  (scaled from 17.72%)
           7693  L1-data-Cache-Prefetch-Misses  (scaled from 22.97%)
        2180945  L1-instruction-Cache-Load-Referencees  (scaled from 28.48%)
          14518  L1-instruction-Cache-Load-Misses  (scaled from 35.00%)
           2405  L1-instruction-Cache-Prefetch-Referencees  (scaled from 34.89%)
          71387  L2-Cache-Load-Referencees  (scaled from 34.94%)
          18732  L2-Cache-Load-Misses  (scaled from 34.92%)
          79918  L2-Cache-Store-Referencees  (scaled from 36.02%)
        1295294  Data-TLB-Cache-Load-Referencees  (scaled from 35.99%)
          30896  Data-TLB-Cache-Load-Misses  (scaled from 33.36%)
        1222030  Instruction-TLB-Cache-Load-Referencees  (scaled from 29.46%)
            357  Instruction-TLB-Cache-Load-Misses  (scaled from 20.46%)
         530888  Branch-Cache-Load-Referencees  (scaled from 11.48%)
           8638  Branch-Cache-Load-Misses  (scaled from 5.09%)
    0.011295149  seconds time elapsed.

Earlier it always shows value 0.

---
 arch/x86/kernel/cpu/perf_counter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/perf_counter.c +1 -1
index ce1ae3f..37facc5 100644
@@ -401,7 +401,7 @@ static const u64 amd_hw_cache_event_ids
 		[ C(RESULT_MISS)   ] = 0x0041, /* Data Cache Misses          */
 	},
 	[ C(OP_WRITE) ] = {
-		[ C(RESULT_ACCESS) ] = 0x0042, /* Data Cache Refills from L2 */
+		[ C(RESULT_ACCESS) ] = 0x0142, /* Data Cache Refills :system */
 		[ C(RESULT_MISS)   ] = 0,
 	},
 	[ C(OP_PREFETCH) ] = {
Signature · 1 line
1.6.0.6
Applied
#2 lore raw
Quoted 40 lines · Jaswinder Singh Rajput

Fix AMD's Data Cache Refills from System event.

By this patch :

./tools/perf/perf stat -e l1d -e l1d-misses -e l1d-write -e l1d-prefetch -e l1d-prefetch-miss -e l1i -e l1i-misses -e l1i-prefetch -e l2 -e l2-misses -e l2-write -e dtlb -e dtlb-misses -e itlb -e itlb-misses -e bpu -e bpu-misses ls /dev/ > /dev/null

Performance counter stats for 'ls /dev/':

        2499484  L1-data-Cache-Load-Referencees  (scaled from 3.97%)
          70347  L1-data-Cache-Load-Misses  (scaled from 7.30%)
           9360  L1-data-Cache-Store-Referencees  (scaled from 8.64%)
          32804  L1-data-Cache-Prefetch-Referencees  (scaled from 17.72%)
           7693  L1-data-Cache-Prefetch-Misses  (scaled from 22.97%)
        2180945  L1-instruction-Cache-Load-Referencees  (scaled from 28.48%)
          14518  L1-instruction-Cache-Load-Misses  (scaled from 35.00%)
           2405  L1-instruction-Cache-Prefetch-Referencees  (scaled from 34.89%)
          71387  L2-Cache-Load-Referencees  (scaled from 34.94%)
          18732  L2-Cache-Load-Misses  (scaled from 34.92%)
          79918  L2-Cache-Store-Referencees  (scaled from 36.02%)
        1295294  Data-TLB-Cache-Load-Referencees  (scaled from 35.99%)
          30896  Data-TLB-Cache-Load-Misses  (scaled from 33.36%)
        1222030  Instruction-TLB-Cache-Load-Referencees  (scaled from 29.46%)
            357  Instruction-TLB-Cache-Load-Misses  (scaled from 20.46%)
         530888  Branch-Cache-Load-Referencees  (scaled from 11.48%)
           8638  Branch-Cache-Load-Misses  (scaled from 5.09%)
    0.011295149  seconds time elapsed.

Earlier it always shows value 0.

---
 arch/x86/kernel/cpu/perf_counter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/perf_counter.c +0 -0
index ce1ae3f..37facc5 100644

arch/x86/kernel/cpu/perf_counter.c static const u64 amd_hw_cache_event_ids · line 407

Quoted 8 lines
arch/x86/kernel/cpu/perf_counter.c +1 -1
@@ -401,7 +401,7 @@ static const u64 amd_hw_cache_event_ids
 		[ C(RESULT_MISS)   ] = 0x0041, /* Data Cache Misses          */
 	},
 	[ C(OP_WRITE) ] = {
-		[ C(RESULT_ACCESS) ] = 0x0042, /* Data Cache Refills from L2 */
+		[ C(RESULT_ACCESS) ] = 0x0142, /* Data Cache Refills :system */
 		[ C(RESULT_MISS)   ] = 0,
 	},
 	[ C(OP_PREFETCH) ] = {

Applied to tip:perfcounters/urgent, thanks Jaswinder!

Ingo

#3 lore raw

[tip:perfcounters/urgent] perf_counter, x8: Fix L1-data-Cache-Store-Referencees for AMD

In reply to Jaswinder Singh Rajput
Commit-ID:  baed11e65b6e4e191199846c78fd33aae5ce30f5
Gitweb:     http://git.kernel.org/tip/baed11e65b6e4e191199846c78fd33aae5ce30f5
Author:     Jaswinder Singh Rajput <[email protected]>
AuthorDate: Sat, 20 Jun 2009 13:19:25 +0530
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sat, 20 Jun 2009 19:42:48 +0200

perf_counter, x8: Fix L1-data-Cache-Store-Referencees for AMD

Fix AMD's Data Cache Refills from System event.

After this patch :

./tools/perf/perf stat -e l1d -e l1d-misses -e l1d-write -e l1d-prefetch -e l1d-prefetch-miss -e l1i -e l1i-misses -e l1i-prefetch -e l2 -e l2-misses -e l2-write -e dtlb -e dtlb-misses -e itlb -e itlb-misses -e bpu -e bpu-misses ls /dev/ > /dev/null

Performance counter stats for 'ls /dev/':

        2499484  L1-data-Cache-Load-Referencees             (scaled from 3.97%)
          70347  L1-data-Cache-Load-Misses                  (scaled from 7.30%)
           9360  L1-data-Cache-Store-Referencees            (scaled from 8.64%)
          32804  L1-data-Cache-Prefetch-Referencees         (scaled from 17.72%)
           7693  L1-data-Cache-Prefetch-Misses              (scaled from 22.97%)
        2180945  L1-instruction-Cache-Load-Referencees      (scaled from 28.48%)
          14518  L1-instruction-Cache-Load-Misses           (scaled from 35.00%)
           2405  L1-instruction-Cache-Prefetch-Referencees  (scaled from 34.89%)
          71387  L2-Cache-Load-Referencees                  (scaled from 34.94%)
          18732  L2-Cache-Load-Misses                       (scaled from 34.92%)
          79918  L2-Cache-Store-Referencees                 (scaled from 36.02%)
        1295294  Data-TLB-Cache-Load-Referencees            (scaled from 35.99%)
          30896  Data-TLB-Cache-Load-Misses                 (scaled from 33.36%)
        1222030  Instruction-TLB-Cache-Load-Referencees     (scaled from 29.46%)
            357  Instruction-TLB-Cache-Load-Misses          (scaled from 20.46%)
         530888  Branch-Cache-Load-Referencees              (scaled from 11.48%)
           8638  Branch-Cache-Load-Misses                   (scaled from 5.09%)
    0.011295149  seconds time elapsed.

Earlier it always shows value 0.

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/cpu/perf_counter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/perf_counter.c +1 -1
index 76dfef2..22eb3a1 100644
@@ -401,7 +401,7 @@ static const u64 amd_hw_cache_event_ids
 		[ C(RESULT_MISS)   ] = 0x0041, /* Data Cache Misses          */
 	},
 	[ C(OP_WRITE) ] = {
-		[ C(RESULT_ACCESS) ] = 0x0042, /* Data Cache Refills from L2 */
+		[ C(RESULT_ACCESS) ] = 0x0142, /* Data Cache Refills :system */
 		[ C(RESULT_MISS)   ] = 0,
 	},
 	[ C(OP_PREFETCH) ] = {
#4 lore raw

[tip:perfcounters/urgent] perf_counter, x8: Fix L1-data-Cache-Store-Referencees for AMD

In reply to Jaswinder Singh Rajput
Commit-ID:  d9f2a5ecb2846d0fd368fb4c45182e43f38e4471
Gitweb:     http://git.kernel.org/tip/d9f2a5ecb2846d0fd368fb4c45182e43f38e4471
Author:     Jaswinder Singh Rajput <[email protected]>
AuthorDate: Sat, 20 Jun 2009 13:19:25 +0530
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 21 Jun 2009 13:25:55 +0200

perf_counter, x8: Fix L1-data-Cache-Store-Referencees for AMD

Fix AMD's Data Cache Refills from System event.

After this patch :

./tools/perf/perf stat -e l1d -e l1d-misses -e l1d-write -e l1d-prefetch -e l1d-prefetch-miss -e l1i -e l1i-misses -e l1i-prefetch -e l2 -e l2-misses -e l2-write -e dtlb -e dtlb-misses -e itlb -e itlb-misses -e bpu -e bpu-misses ls /dev/ > /dev/null

Performance counter stats for 'ls /dev/':

        2499484  L1-data-Cache-Load-Referencees             (scaled from 3.97%)
          70347  L1-data-Cache-Load-Misses                  (scaled from 7.30%)
           9360  L1-data-Cache-Store-Referencees            (scaled from 8.64%)
          32804  L1-data-Cache-Prefetch-Referencees         (scaled from 17.72%)
           7693  L1-data-Cache-Prefetch-Misses              (scaled from 22.97%)
        2180945  L1-instruction-Cache-Load-Referencees      (scaled from 28.48%)
          14518  L1-instruction-Cache-Load-Misses           (scaled from 35.00%)
           2405  L1-instruction-Cache-Prefetch-Referencees  (scaled from 34.89%)
          71387  L2-Cache-Load-Referencees                  (scaled from 34.94%)
          18732  L2-Cache-Load-Misses                       (scaled from 34.92%)
          79918  L2-Cache-Store-Referencees                 (scaled from 36.02%)
        1295294  Data-TLB-Cache-Load-Referencees            (scaled from 35.99%)
          30896  Data-TLB-Cache-Load-Misses                 (scaled from 33.36%)
        1222030  Instruction-TLB-Cache-Load-Referencees     (scaled from 29.46%)
            357  Instruction-TLB-Cache-Load-Misses          (scaled from 20.46%)
         530888  Branch-Cache-Load-Referencees              (scaled from 11.48%)
           8638  Branch-Cache-Load-Misses                   (scaled from 5.09%)
    0.011295149  seconds time elapsed.

Earlier it always shows value 0.

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/cpu/perf_counter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/perf_counter.c +1 -1
index 76dfef2..22eb3a1 100644
@@ -401,7 +401,7 @@ static const u64 amd_hw_cache_event_ids
 		[ C(RESULT_MISS)   ] = 0x0041, /* Data Cache Misses          */
 	},
 	[ C(OP_WRITE) ] = {
-		[ C(RESULT_ACCESS) ] = 0x0042, /* Data Cache Refills from L2 */
+		[ C(RESULT_ACCESS) ] = 0x0142, /* Data Cache Refills :system */
 		[ C(RESULT_MISS)   ] = 0,
 	},
 	[ C(OP_PREFETCH) ] = {