Skip to contentSkip to conversation

x86-64: remove unnecessary spill/reload of rbx from memcpy

PATCH In review Jan Beulich 1 participant 2 messages Mar 12, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86-64: remove unnecessary spill/reload of rbx from memcpy

This should slightly improve its performance.

---
 arch/x86/lib/memcpy_64.S |    7 -------
 1 file changed, 7 deletions(-)
arch/x86/lib/memcpy_64.S +0 -7
@@ -33,9 +33,6 @@ ENDPROC(memcpy_c)
 ENTRY(__memcpy)
 ENTRY(memcpy)
 	CFI_STARTPROC
-	pushq %rbx
-	CFI_ADJUST_CFA_OFFSET 8
-	CFI_REL_OFFSET rbx, 0
 	movq %rdi,%rax
 
 	movl %edx,%ecx
@@ -102,11 +99,7 @@ ENTRY(memcpy)
 	jnz .Lloop_1
 
 .Lende:
-	popq %rbx
-	CFI_ADJUST_CFA_OFFSET -8
-	CFI_RESTORE rbx
 	ret
-.Lfinal:
 	CFI_ENDPROC
 ENDPROC(memcpy)
 ENDPROC(__memcpy)
#1 lore raw
Commit-ID:  dd1ef4ec4721ddc0a1f2b73a4f67930cb320665c
Gitweb:     http://git.kernel.org/tip/dd1ef4ec4721ddc0a1f2b73a4f67930cb320665c
Author:     "Jan Beulich" <[email protected]>
AuthorDate: Thu, 12 Mar 2009 10:47:13 +0000
Commit:     Ingo Molnar <[email protected]>
CommitDate: Thu, 12 Mar 2009 12:04:47 +0100

x86-64: remove unnecessary spill/reload of rbx from memcpy

Impact: micro-optimization

This should slightly improve its performance.

LKML-Reference: <[email protected]>

---
 arch/x86/lib/memcpy_64.S |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
arch/x86/lib/memcpy_64.S +0 -7
index c22981f..10c0676 100644
@@ -33,9 +33,6 @@ ENDPROC(memcpy_c)
 ENTRY(__memcpy)
 ENTRY(memcpy)
 	CFI_STARTPROC
-	pushq %rbx
-	CFI_ADJUST_CFA_OFFSET 8
-	CFI_REL_OFFSET rbx, 0
 	movq %rdi,%rax
 
 	movl %edx,%ecx
@@ -102,11 +99,7 @@ ENTRY(memcpy)
 	jnz .Lloop_1
 
 .Lende:
-	popq %rbx
-	CFI_ADJUST_CFA_OFFSET -8
-	CFI_RESTORE rbx
 	ret
-.Lfinal:
 	CFI_ENDPROC
 ENDPROC(memcpy)
 ENDPROC(__memcpy)