Skip to contentSkip to conversation

x86, gcc-4.6: Use gcc -m options when building vdso

tip:x86/urgent tip-bot for H. Peter Anvin 1 participant 1 message Dec 14, 2010 x86

lore
Share & tools
lore
#0 lore raw
Commit-ID:  de2a8cf98ecdde25231d6c5e7901e2cffaf32af9
Gitweb:     http://git.kernel.org/tip/de2a8cf98ecdde25231d6c5e7901e2cffaf32af9
Author:     H. Peter Anvin <[email protected]>
AuthorDate: Mon, 13 Dec 2010 16:01:38 -0800
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Mon, 13 Dec 2010 16:08:37 -0800

x86, gcc-4.6: Use gcc -m options when building vdso

The vdso Makefile passes linker-style -m options not to the linker but to gcc. This happens to work with earlier gcc, but fails with gcc 4.6. Pass gcc-style -m options, instead.

Note: all currently supported versions of gcc supports -m32, so there is no reason to conditionalize it any more.

LKML-Reference: <tip-*@git.kernel.org>
Cc: <[email protected]>

---
 arch/x86/vdso/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/vdso/Makefile +2 -2
index 4a2afa1..b6552b1 100644
@@ -25,7 +25,7 @@ targets += vdso.so vdso.so.dbg vdso.lds $(vobjs-y)
 
 export CPPFLAGS_vdso.lds += -P -C
 
-VDSO_LDFLAGS_vdso.lds = -m elf_x86_64 -Wl,-soname=linux-vdso.so.1 \
+VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \
 		      	-Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096
 
 $(obj)/vdso.o: $(src)/vdso.S $(obj)/vdso.so
@@ -69,7 +69,7 @@ vdso32.so-$(VDSO32-y)		+= sysenter
 vdso32-images			= $(vdso32.so-y:%=vdso32-%.so)
 
 CPPFLAGS_vdso32.lds = $(CPPFLAGS_vdso.lds)
-VDSO_LDFLAGS_vdso32.lds = -m elf_i386 -Wl,-soname=linux-gate.so.1
+VDSO_LDFLAGS_vdso32.lds = -m32 -Wl,-soname=linux-gate.so.1
 
 # This makes sure the $(obj) subdirectory exists even though vdso32/
 # is not a kbuild sub-make subdirectory.