tools: Adopt __printf from kernel sources
tip-bot for Arnaldo Carvalho de Melo
merge botCommit-ID: afaed6d3e4aa56e939b496aafa5c97852e223122 Gitweb: http://git.kernel.org/tip/afaed6d3e4aa56e939b496aafa5c97852e223122 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Fri, 16 Jun 2017 11:57:54 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 19 Jun 2017 15:25:26 -0300
tools: Adopt __printf from kernel sources
To have a more compact way to ask the compiler to perform printf like vargargs validation.
v2: Fixed up build on arm, squashing a patch by Kim Phillips, thanks!
Cc Adrian Hunter <[email protected]>
Cc Alexander Shishkin <[email protected]>
Cc David Ahern <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Kim Phillips <[email protected]>
Cc Mathieu Poirier <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Wang Nan <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/include/linux/compiler-gcc.h | 2 ++ tools/perf/arch/arm/util/cs-etm.c | 4 ++-- tools/perf/util/cache.h | 3 ++- tools/perf/util/debug.h | 11 ++++++----- tools/perf/util/intel-pt-decoder/intel-pt-log.h | 4 ++-- tools/perf/util/probe-event.h | 4 ++-- tools/perf/util/strbuf.h | 4 ++-- tools/perf/util/util.h | 12 +++--------- 8 files changed, 21 insertions(+), 23 deletions(-)
tools/include/linux/compiler-gcc.h +2 -0
@@ -21,3 +21,5 @@#define __must_be_array (a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))#define __noreturn __attribute__((noreturn)) + +#define __printf (a, b) __attribute__((format(printf, a, b)))
tools/perf/arch/arm/util/cs-etm.c +2 -2
@@ -17,6 +17,7 @@#include <api/fs/fs.h> #include <linux/bitops.h> +#include <linux/compiler.h> #include <linux/coresight-pmu.h> #include <linux/kernel.h> #include <linux/log2.h>
@@ -583,8 +584,7 @@ static FILE *cs_device__open_file(const char *name) } -static __attribute__((format (printf,2 ,3 ))) -int cs_device__print_file (const char *name,const char *fmt, ...) +static int __printf(2, 3) cs_device__print_file(const char *name, const char *fmt, ...) {va_list args;FILE *file;
tools/perf/util/cache.h +2 -1
@@ -5,6 +5,7 @@#include <subcmd/pager.h> #include "../ui/ui.h" +#include <linux/compiler.h> #include <linux/string.h> #define CMD_EXEC_PATH "--exec-path"
@@ -24,6 +25,6 @@ static inline int is_absolute_path(const char *path) return path[0] == '/'; } -char *mkpath (const char *fmt, ...) __attribute__((format (printf,1 ,2 ))); +char *mkpath (const char *fmt, ...)__printf (1 ,2 );#endif /* __PERF_CACHE_H */
tools/perf/util/debug.h +6 -5
@@ -4,6 +4,7 @@#include <stdbool.h> #include <string.h> +#include <linux/compiler.h> #include "event.h" #include "../ui/helpline.h" #include "../ui/progress.h"
@@ -40,16 +41,16 @@ extern int debug_data_convert;#define STRERR_BUFSIZE 128/* For the buffer size of str_error_r */ -int dump_printf (const char *fmt, ...) __attribute__((format (printf,1 ,2 ))); +int dump_printf(const char *fmt, ...) __printf(1, 2);void trace_event (union perf_event *event); -int ui__error (const char *format, ...) __attribute__((format (printf,1 ,2 ))); -int ui__warning (const char *format, ...) __attribute__((format (printf,1 ,2 ))); +int ui__error(const char *format, ...) __printf(1, 2); +int ui__warning(const char *format, ...) __printf(1, 2);void pr_stat (const char *fmt, ...); -int eprintf (int level,int var,const char *fmt, ...) __attribute__((format (printf,3 ,4 ))); -int eprintf_time (int level,int var,u64 t,const char *fmt, ...) __attribute__((format (printf,4 ,5 ))); +int eprintf(int level, int var, const char *fmt, ...) __printf(3, 4); +int eprintf_time(int level, int var, u64 t, const char *fmt, ...) __printf(4, 5);int veprintf (int level,int var,const char *fmt,va_list args);int perf_debug_option (const char *str);
tools/perf/util/intel-pt-decoder/intel-pt-log.h +2 -2
@@ -16,6 +16,7 @@#ifndef INCLUDE__INTEL_PT_LOG_H__ #define INCLUDE__INTEL_PT_LOG_H__ +#include <linux/compiler.h> #include <stdint.h> #include <inttypes.h>
@@ -34,8 +35,7 @@ void __intel_pt_log_insn(struct intel_pt_insn *intel_pt_insn, uint64_t ip);void __intel_pt_log_insn_no_data (struct intel_pt_insn *intel_pt_insn,uint64_t ip); -__attribute__((format (printf,1 ,2 ))) -void __intel_pt_log (const char *fmt, ...); +void __intel_pt_log(const char *fmt, ...) __printf(1, 2);#define intel_pt_log (fmt, ...) \ do { \
tools/perf/util/probe-event.h +2 -2
@@ -1,6 +1,7 @@#ifndef _PROBE_EVENT_H#define _PROBE_EVENT_H +#include <linux/compiler.h> #include <stdbool.h> #include "intlist.h"
@@ -171,8 +172,7 @@ void arch__fix_tev_from_maps(struct perf_probe_event *pev, struct symbol *sym);/* If there is no space to write, returns -E2BIG. */ -int e_snprintf (char *str,size_t size,const char *format, ...) - __attribute__((format (printf,3 ,4 ))); +int e_snprintf(char *str, size_t size, const char *format, ...) __printf(3, 4);/* Maximum index number of event-name postfix */ #define MAX_EVENT_INDEX 1024
tools/perf/util/strbuf.h +2 -2
@@ -42,6 +42,7 @@#include <stdarg.h> #include <stddef.h> #include <string.h> +#include <linux/compiler.h> #include <sys/types.h> extern char strbuf_slopbuf[];
@@ -85,8 +86,7 @@ static inline int strbuf_addstr(struct strbuf *sb, const char *s) {return strbuf_add (sb, s,strlen (s)); } -__attribute__((format (printf,2 ,3 ))) -int strbuf_addf (struct strbuf *sb,const char *fmt, ...); +int strbuf_addf(struct strbuf *sb, const char *fmt, ...) __printf(2, 3);/* XXX: if read fails, any partial read is undone */ ssize_t strbuf_read (struct strbuf *,int fd,ssize_t hint);
tools/perf/util/util.h +3 -9
@@ -14,17 +14,11 @@#include <linux/compiler.h> #include <linux/types.h> -#ifndef __GNUC__ -#ifndef __attribute__ -#define __attribute__ (x) -#endif -#endif -/* General helper functions */ void usage (const char *err)__noreturn ; -void die (const char *err, ...)__noreturn __attribute__((format (printf,1 ,2 ))); -int error (const char *err, ...) __attribute__((format (printf,1 ,2 ))); -void warning (const char *err, ...) __attribute__((format (printf,1 ,2 ))); +void die(const char *err, ...) __noreturn __printf(1, 2); +int error(const char *err, ...) __printf(1, 2); +void warning(const char *err, ...) __printf(1, 2);void set_warning_routine (void (*routine)(const char *err,va_list params));