Skip to contentSkip to conversation

perf report: Fix 32-bit printf format

tip:perfcounters/core tip-bot for Ingo Molnar 1 participant 1 message Jun 15, 2009 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  e2eae0f5605b90a0838608043c21050b08b6dd95
Gitweb:     http://git.kernel.org/tip/e2eae0f5605b90a0838608043c21050b08b6dd95
Author:     Ingo Molnar <[email protected]>
AuthorDate: Mon, 15 Jun 2009 16:15:19 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 15 Jun 2009 16:18:02 +0200

perf report: Fix 32-bit printf format

Yong Wang reported the following compiler warning:

builtin-report.c: In function 'process_overflow_event':
builtin-report.c:984: error: cast to pointer from integer of different size

Which happens because we try to print ->ips[] out with a limited format, losing the high 32 bits. Print it out using %016Lx instead.

Cc Peter Zijlstra <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>

LKML-Reference: <new-submission>

---
 tools/perf/builtin-report.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
tools/perf/builtin-report.c +1 -1
index 1e2f5dd..f86bb07 100644
@@ -982,7 +982,7 @@ process_overflow_event(event_t *event, unsigned long offset, unsigned long head)
 				chain->nr);
 
 			for (i = 0; i < chain->nr; i++)
-				dprintf("..... %2d: %p\n", i, (void *)chain->ips[i]);
+				dprintf("..... %2d: %016Lx\n", i, chain->ips[i]);
 		}
 		if (collapse_syscalls) {
 			/*