Skip to contentSkip to conversation

reboot: re-enable the function of variable reboot_default

PATCH In review Chuansheng Liu 3 participants 4 messages Sep 9, 2013 – Sep 10, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reboot: re-enable the function of variable reboot_default

commit b3a5d02ee070c(reboot: move arch/x86 reboot= handling to generic kernel) did some cleanup for reboot= command line, but it made the reboot_default to be invalidated.

The default value of variable reboot_default should be 1, and if command line reboot= is not set, system will use the default reboot mode.

---
 kernel/reboot.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
kernel/reboot.c +8 -1
index 269ed93..d82eb6e 100644
@@ -32,7 +32,14 @@ EXPORT_SYMBOL(cad_pid);
 #endif
 enum reboot_mode reboot_mode DEFAULT_REBOOT_MODE;
 
-int reboot_default;
+/*
+ * This variable is used privately to keep track of whether or not
+ * reboot_type is still set to its default value (i.e., reboot= hasn't
+ * been set on the command line).  This is needed so that we can
+ * suppress DMI scanning for reboot quirks.  Without it, it's
+ * impossible to override a faulty reboot quirk without recompiling.
+*/
+int reboot_default = 1;
 int reboot_cpu;
 enum reboot_type reboot_type = BOOT_ACPI;
 int reboot_force;
Signature · 1 line
1.7.0.4
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Chuansheng Liu

commit b3a5d02ee070c(reboot: move arch/x86 reboot= handling to generic kernel)

The commit id was really 1b3a5d02ee070c

Quoted 8 lines

did some cleanup for reboot= command line, but it made the reboot_default to be invalidated.

The default value of variable reboot_default should be 1, and if command line reboot= is not set, system will use the default reboot mode.

Thank you for fixing my bug.

Note: My email address used to be [email protected]

Quoted 34 lines
---
 kernel/reboot.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
kernel/reboot.c +8 -1
index 269ed93..d82eb6e 100644
@@ -32,7 +32,14 @@ EXPORT_SYMBOL(cad_pid);
 #endif
 enum reboot_mode reboot_mode DEFAULT_REBOOT_MODE;
 
-int reboot_default;
+/*
+ * This variable is used privately to keep track of whether or not
+ * reboot_type is still set to its default value (i.e., reboot= hasn't
+ * been set on the command line).  This is needed so that we can
+ * suppress DMI scanning for reboot quirks.  Without it, it's
+ * impossible to override a faulty reboot quirk without recompiling.
+*/
+int reboot_default = 1;
 int reboot_cpu;
 enum reboot_type reboot_type = BOOT_ACPI;
 int reboot_force;
Signature · 9 lines
1.7.0.4



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
#2 lore raw
Quoted 24 lines

-----Original Message-----
From: Robin Holt [mailto:[email protected]]
Sent: Monday, September 09, 2013 11:07 PM
To: Liu, Chuansheng
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Li, Fei
Subject: Re: [PATCH] reboot: re-enable the function of variable reboot_default

Quoted 2 lines · Chuansheng Liu

commit b3a5d02ee070c(reboot: move arch/x86 reboot= handling to generic

kernel)

The commit id was really 1b3a5d02ee070c

Quoted 6 lines

did some cleanup for reboot= command line, but it made the reboot_default to be invalidated.

The default value of variable reboot_default should be 1, and if command line reboot= is not set, system will use the default reboot mode.

Quoted 8 lines
Quoted 2 lines

Thank you for fixing my bug.

Note: My email address used to be [email protected]

Thanks Robin to ack and notify, I also was wondering why the email is undelivered to your old EMAIL:)

#3 lore raw

[tip:x86/reboot] reboot: Re-enable the function of variable reboot_default

In reply to Chuansheng Liu
reboot: Re-enable the function of variable reboot_default
Commit-ID:  e635be963eb2e9883e8124b75dff0c2e29857a6e
Gitweb:     http://git.kernel.org/tip/e635be963eb2e9883e8124b75dff0c2e29857a6e
Author:     Chuansheng Liu <[email protected]>
AuthorDate: Mon, 9 Sep 2013 19:49:40 +0800
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Tue, 10 Sep 2013 08:48:40 -0700

reboot: Re-enable the function of variable reboot_default

Commit 1b3a5d02ee070c (reboot: move arch/x86 reboot= handling to generic kernel) did some cleanup for reboot= command line, but it made the reboot_default to be invalidated.

The default value of variable reboot_default should be 1, and if command line reboot= is not set, system will use the default reboot mode.

---
 kernel/reboot.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
kernel/reboot.c +8 -1
index 269ed93..d82eb6e 100644
@@ -32,7 +32,14 @@ EXPORT_SYMBOL(cad_pid);
 #endif
 enum reboot_mode reboot_mode DEFAULT_REBOOT_MODE;
 
-int reboot_default;
+/*
+ * This variable is used privately to keep track of whether or not
+ * reboot_type is still set to its default value (i.e., reboot= hasn't
+ * been set on the command line).  This is needed so that we can
+ * suppress DMI scanning for reboot quirks.  Without it, it's
+ * impossible to override a faulty reboot quirk without recompiling.
+*/
+int reboot_default = 1;
 int reboot_cpu;
 enum reboot_type reboot_type = BOOT_ACPI;
 int reboot_force;