Skip to contentSkip to conversation

x86: Fix mkcapflags.sh bash-ism again

PATCH In review Sylvain BERTRAND 3 participants 5 messages Dec 29, 2014 – May 11, 2015 x86

lore
Share & tools
lore

Sylvain BERTRAND

author
#0 lore raw

PATCH 1/1 x86: Fix mkcapflags.sh bash-ism again

Chocked while compiling linux with dash shell instead of bash shell. See:
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05

Cc Ingo Molnar <[email protected]>
Signed-off-by Sylvain BERTRAND <[email protected]>

---

Forgot that one. More to come.

arch/x86/kernel/cpu/mkcapflags.sh +1 -1
@@ -6,7 +6,7 @@
 IN=$1
 OUT=$2
 
-function dump_array()
+dump_array()
 {
 	ARRAY=$1
 	SIZE=$2
merge bot
#1 lore raw

[tip:x86/build] x86/build: Fix mkcapflags.sh bash-ism

x86/build: Fix mkcapflags.sh bash-ism
Commit-ID:  e85bd9892c4f10fd20fc575e62327efb7c77015d
Gitweb:     http://git.kernel.org/tip/e85bd9892c4f10fd20fc575e62327efb7c77015d
Author:     Sylvain BERTRAND <[email protected]>
AuthorDate: Mon, 29 Dec 2014 16:43:24 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 19 Feb 2015 02:21:00 +0100

x86/build: Fix mkcapflags.sh bash-ism

Chocked while compiling linux with dash shell instead of bash shell. See:

http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05

Signed-off-by Sylvain BERTRAND <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Thomas Gleixner <[email protected]>
Link http://lkml.kernel.org/r/20141229154324.GA27533@dhcppc1 open here
Signed-off-by Ingo Molnar <[email protected]>
---
 arch/x86/kernel/cpu/mkcapflags.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/mkcapflags.sh +1 -1
index 36d99a3..3f20710 100644
@@ -6,7 +6,7 @@
 IN=$1
 OUT=$2
 
-function dump_array()
+dump_array()
 {
 	ARRAY=$1
 	SIZE=$2
author
#2 lore raw
In reply to Sylvain BERTRAND

While compiling linux, dash shell reports a bash-ism:

/src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: 9: /src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: Syntax error: "(" unexpected

See:
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05

Cc Ingo Molnar <[email protected]>
Signed-off-by Sylvain BERTRAND <[email protected]>

---
Forgot that fix:

arch/x86/kernel/cpu/mkcapflags.sh +1 -1
@@ -6,7 +6,7 @@
 IN=$1
 OUT=$2
 
-function dump_array()
+dump_array()
 {
 	ARRAY=$1
 	SIZE=$2
author
#3 lore raw
Quoted 14 lines · On Mon, Apr 27, 2015 at 03:21:02PM +0000, [email protected] wrote:

While compiling linux, dash shell reports a bash-ism:

/src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: 9: /src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: Syntax error: "(" unexpected

See:
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05

Cc Ingo Molnar <[email protected]>
Signed-off-by Sylvain BERTRAND <[email protected]>

---
Forgot that fix:

arch/x86/kernel/cpu/mkcapflags.sh line 12

Quoted 8 lines
arch/x86/kernel/cpu/mkcapflags.sh +1 -1
@@ -6,7 +6,7 @@
 IN=$1
 OUT=$2
 
-function dump_array()
+dump_array()
 {
 	ARRAY=$1
 	SIZE=$2

What's up with this patch?

regards,

Signature · 1 line
Sylvain
#4 lore raw
Quoted 18 lines · * [email protected] <[email protected]> wrote:
Quoted 17 lines · On Mon, Apr 27, 2015 at 03:21:02PM +0000, [email protected] wrote:

While compiling linux, dash shell reports a bash-ism:

/src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: 9: /src/linux-4.0/arch/x86/kernel/cpu/mkcapflags.sh: Syntax error: "(" unexpected

See:
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05

Cc Ingo Molnar <[email protected]>
Signed-off-by Sylvain BERTRAND <[email protected]>

---
Forgot that fix:

arch/x86/kernel/cpu/mkcapflags.sh +0 -0
@@ -6,7 +6,7 @@
 IN=$1
 OUT=$2
Quoted 7 lines

arch/x86/kernel/cpu/mkcapflags.sh line 12

Quoted 5 lines
arch/x86/kernel/cpu/mkcapflags.sh +1 -1
-function dump_array()
+dump_array()
 {
 	ARRAY=$1
 	SIZE=$2

What's up with this patch?

It's upstream, as commit:

e85bd9892c4f x86/build: Fix mkcapflags.sh bash-ism

thanks,

Ingo