Skip to contentSkip to conversation

kernel/time/jiffies.c - make variable static

PATCH New Valdis Kl=?utf-8?Q?=c4=93?=tnieks 2 participants 2 messages Mar 12, 2019 – Mar 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/time/jiffies.c - make variable static

sparse complains:

CHECK kernel/time/jiffies.c
kernel/time/jiffies.c:92:20: warning: symbol 'refined_jiffies' was not declared. Should it be static?

__clocksource_register() is passed a pointer, and nothing else refers to it. Make it static.

---

kernel/time/jiffies.c +1 -1
index dc1b6f1929f9..ac9c03dd6c7d 100644
@@ -89,7 +89,7 @@ struct clocksource * __init __weak clocksource_default_clock(void)
 	return &clocksource_jiffies;
 }
 
-struct clocksource refined_jiffies;
+static struct clocksource refined_jiffies;
 
 int register_refined_jiffies(long cycles_per_second)
 {
#1 lore raw

[tip:timers/urgent] time/jiffies: Make refined_jiffies static

time/jiffies: Make refined_jiffies static
Commit-ID:  e8750053d64a3317cbc15f8341f0f11ca751bfeb
Gitweb:     https://git.kernel.org/tip/e8750053d64a3317cbc15f8341f0f11ca751bfeb
Author:     Valdis Kletnieks <[email protected]>
AuthorDate: Tue, 12 Mar 2019 04:38:35 -0400
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Fri, 22 Mar 2019 13:38:26 +0100

time/jiffies: Make refined_jiffies static

sparse complains:

CHECK kernel/time/jiffies.c
kernel/time/jiffies.c:92:20: warning: symbol 'refined_jiffies' was not
declared. Should it be static?

Its only used in file scope. Make it static.

---
 kernel/time/jiffies.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/jiffies.c +1 -1
index dc1b6f1929f9..ac9c03dd6c7d 100644
@@ -89,7 +89,7 @@ struct clocksource * __init __weak clocksource_default_clock(void)
 	return &clocksource_jiffies;
 }
 
-struct clocksource refined_jiffies;
+static struct clocksource refined_jiffies;
 
 int register_refined_jiffies(long cycles_per_second)
 {