perf: Rename cpu_map__all() to cpu_map__empty()
PATCH 1/1 perf: Rename cpu_map__all() to cpu_map__empty()
From: Sukadev Bhattiprolu <[email protected]>
Date: Wed, 22 May 2013 17:42:38 -0700
Subject: [PATCH] Rename cpu_map__all() to cpu_map__empty().
The CPU map is in an "empty" (or not-applicable) state when monitoring specific threads.
cpu_map__all() returns true if the CPU map is in this empty state (i.e for the 'empty_cpu_map' or if we created the map via cpu_map__dummy_new().
The name, cpu_map__all(), is misleading, because even when monitoring all CPUs, (eg: perf record -a), cpu_map__all() returns false.
Rename cpu_map__all() to cpu_map__empty().
--- tools/perf/util/cpumap.h | 2 +- tools/perf/util/evlist.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
tools/perf/util/cpumap.h +1 -1
@@ -41,7 +41,7 @@ static inline int cpu_map__nr(const struct cpu_map *map)return map ? map->nr :1 ; } -static inline bool cpu_map__all (const struct cpu_map *map) +static inline bool cpu_map__empty (const struct cpu_map *map) {return map ? map->map[0 ] ==-1 : true; }
tools/perf/util/evlist.c +2 -2
@@ -421,7 +421,7 @@ void perf_evlist__munmap(struct perf_evlist *evlist)static int perf_evlist__alloc_mmap (struct perf_evlist *evlist) { evlist->nr_mmaps =cpu_map__nr (evlist->cpus); -if (cpu_map__all (evlist->cpus)) +if (cpu_map__empty (evlist->cpus)) evlist->nr_mmaps =thread_map__nr (evlist->threads); evlist->mmap =zalloc (evlist->nr_mmaps *sizeof (struct perf_mmap ));return evlist->mmap !=NULL ?0 : -ENOMEM ;
@@ -573,7 +573,7 @@ int perf_evlist__mmap(struct perf_evlist *evlist, unsigned int pages,return -ENOMEM ; } -if (cpu_map__all (cpus)) +if (cpu_map__empty (cpus))return perf_evlist__mmap_per_thread (evlist, prot, mask);return perf_evlist__mmap_per_cpu (evlist, prot, mask);
Signature · 1 line
1.7.1
tip-bot for Sukadev Bhattiprolu
merge bot[tip:perf/core] perf tools: Rename cpu_map__all() to cpu_map__empty()
perf tools: Rename cpu_map__all() to cpu_map__empty()
Commit-ID: ec1e7e437ac47ecf7b4e07241036b1e1c3366012 Gitweb: http://git.kernel.org/tip/ec1e7e437ac47ecf7b4e07241036b1e1c3366012 Author: Sukadev Bhattiprolu <[email protected]> AuthorDate: Wed, 22 May 2013 17:42:38 -0700 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Fri, 12 Jul 2013 13:45:44 -0300
perf tools: Rename cpu_map__all() to cpu_map__empty()
The CPU map is in an "empty" (or not-applicable) state when monitoring specific threads.
cpu_map__all() returns true if the CPU map is in this empty state (i.e for the 'empty_cpu_map' or if we created the map via cpu_map__dummy_new().
The name, cpu_map__all(), is misleading, because even when monitoring all CPUs, (eg: perf record -a), cpu_map__all() returns false.
Rename cpu_map__all() to cpu_map__empty().
--- tools/perf/util/cpumap.h | 2 +- tools/perf/util/evlist.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
tools/perf/util/cpumap.h +1 -1
@@ -41,7 +41,7 @@ static inline int cpu_map__nr(const struct cpu_map *map)return map ? map->nr :1 ; } -static inline bool cpu_map__all (const struct cpu_map *map) +static inline bool cpu_map__empty (const struct cpu_map *map) {return map ? map->map[0 ] ==-1 : true; }
tools/perf/util/evlist.c +2 -2
@@ -421,7 +421,7 @@ void perf_evlist__munmap(struct perf_evlist *evlist)static int perf_evlist__alloc_mmap (struct perf_evlist *evlist) { evlist->nr_mmaps =cpu_map__nr (evlist->cpus); -if (cpu_map__all (evlist->cpus)) +if (cpu_map__empty (evlist->cpus)) evlist->nr_mmaps =thread_map__nr (evlist->threads); evlist->mmap =zalloc (evlist->nr_mmaps *sizeof (struct perf_mmap ));return evlist->mmap !=NULL ?0 : -ENOMEM ;
@@ -573,7 +573,7 @@ int perf_evlist__mmap(struct perf_evlist *evlist, unsigned int pages,return -ENOMEM ; } -if (cpu_map__all (cpus)) +if (cpu_map__empty (cpus))return perf_evlist__mmap_per_thread (evlist, prot, mask);return perf_evlist__mmap_per_cpu (evlist, prot, mask);