Skip to contentSkip to conversation

perf ui tui: Register the error callbacks before initializing the widgets

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Oct 23, 2015 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  464b01a48eb6be48bc58332e029760b5e40ea119
Gitweb:     http://git.kernel.org/tip/464b01a48eb6be48bc58332e029760b5e40ea119
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 22 Oct 2015 16:44:17 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 22 Oct 2015 16:44:17 -0300

perf ui tui: Register the error callbacks before initializing the widgets

I.e. we want to tell the user about errors found during, for instance, the ui_browser initialization, so that a call to ui__warning() appears as a window waiting for a key to be pressed.

Cc Adrian Hunter <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Stephane Eranian <[email protected]>
Cc Wang Nan <[email protected]>
---
 tools/perf/ui/tui/setup.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
tools/perf/ui/tui/setup.c +4 -4
index 60d1f29..7dfeba0 100644
@@ -141,10 +141,6 @@ int ui__init(void)
 
 	SLkp_define_keysym((char *)"^(kB)", SL_KEY_UNTAB);
 
-	ui_helpline__init();
-	ui_browser__init();
-	tui_progress__init();
-
 	signal(SIGSEGV, ui__signal_backtrace);
 	signal(SIGFPE, ui__signal_backtrace);
 	signal(SIGINT, ui__signal);
@@ -153,6 +149,10 @@ int ui__init(void)
 
 	perf_error__register(&perf_tui_eops);
 
+	ui_helpline__init();
+	ui_browser__init();
+	tui_progress__init();
+
 	hist_browser__init_hpp();
 out:
 	return err;