Skip to contentSkip to conversation

perf metricgroup: Use strsep()

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Jul 3, 2019 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  80e9073f1f4473639d585b89ebc9130bb47920e8
Gitweb:     https://git.kernel.org/tip/80e9073f1f4473639d585b89ebc9130bb47920e8
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Wed, 26 Jun 2019 11:21:47 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 26 Jun 2019 11:31:43 -0300

perf metricgroup: Use strsep()

No change in behaviour intended, trivial optimization done by avoiding looking for spaces in 'g' right after setting it to "No_group".

---
 tools/perf/util/metricgroup.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tools/perf/util/metricgroup.c +1 -2
index a0cf3cd95ced..90cd84e2a503 100644
@@ -308,10 +308,9 @@ void metricgroup__print(bool metrics, bool metricgroups, char *filter,
 				struct mep *me;
 				char *s;
 
+				g = skip_spaces(g);
 				if (*g == 0)
 					g = "No_group";
-				while (isspace(*g))
-					g++;
 				if (filter && !strstr(g, filter))
 					continue;
 				if (raw)