Skip to contentSkip to conversation

genirq: remove unnecessary memset() calls.

PATCH New Weongyo Jeong 2 participants 2 messages Mar 31, 2016 – Jun 10, 2016 IRQ

lore
Share & tools
lore

Weongyo Jeong

author
#0 lore raw

PATCH 1/1 genirq: remove unnecessary memset() calls.

sprintf() and snprintf() implementation of kernel guarantees that its result is terminated with null byte if size is larger than 0. So we don't need to call memset() at all.

Signed-off-by Weongyo Jeong <[email protected]>
---
 kernel/irq/proc.c | 3 ---
 1 file changed, 3 deletions(-)
kernel/irq/proc.c +0 -3
index 4e1b947..90dfbca 100644
@@ -311,7 +311,6 @@ void register_handler_proc(unsigned int irq, struct irqaction *action)
 					!name_unique(irq, action))
 		return;
 
-	memset(name, 0, MAX_NAMELEN);
 	snprintf(name, MAX_NAMELEN, "%s", action->name);
 
 	/* create /proc/irq/1234/handler/ */

@@ -340,7 +339,6 @@ void register_irq_proc(unsigned int irq, struct irq_desc *desc)
 	if (desc->dir)
 		goto out_unlock;
 
-	memset(name, 0, MAX_NAMELEN);
 	sprintf(name, "%d", irq);
 
 	/* create /proc/irq/1234 */

@@ -386,7 +384,6 @@ void unregister_irq_proc(unsigned int irq, struct irq_desc *desc)
 #endif
 	remove_proc_entry("spurious", desc->dir);
 
-	memset(name, 0, MAX_NAMELEN);
 	sprintf(name, "%u", irq);
 	remove_proc_entry(name, root_irq_dir);
 }
Signature · 1 line
2.1.3
merge bot
#1 lore raw

[tip:irq/core] genirq: Remove unnecessary memset() calls

genirq: Remove unnecessary memset() calls
Commit-ID:  ff5b706f5189fe8d2a6fd576b491b769ec1d29d3
Gitweb:     http://git.kernel.org/tip/ff5b706f5189fe8d2a6fd576b491b769ec1d29d3
Author:     Weongyo Jeong <[email protected]>
AuthorDate: Thu, 31 Mar 2016 12:15:03 -0700
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Fri, 10 Jun 2016 17:07:50 +0200

genirq: Remove unnecessary memset() calls

sprintf() and snprintf() implementation of kernel guarantees that its result is terminated with null byte if size is larger than 0. So we don't need to call memset() at all.

Signed-off-by Weongyo Jeong <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Thomas Gleixner <[email protected]>
---
 kernel/irq/proc.c | 3 ---
 1 file changed, 3 deletions(-)
kernel/irq/proc.c +0 -3
index 50a8f28..f30425d 100644
@@ -311,7 +311,6 @@ void register_handler_proc(unsigned int irq, struct irqaction *action)
 					!name_unique(irq, action))
 		return;
 
-	memset(name, 0, MAX_NAMELEN);
 	snprintf(name, MAX_NAMELEN, "%s", action->name);
 
 	/* create /proc/irq/1234/handler/ */

@@ -340,7 +339,6 @@ void register_irq_proc(unsigned int irq, struct irq_desc *desc)
 	if (desc->dir)
 		goto out_unlock;
 
-	memset(name, 0, MAX_NAMELEN);
 	sprintf(name, "%d", irq);
 
 	/* create /proc/irq/1234 */

@@ -386,7 +384,6 @@ void unregister_irq_proc(unsigned int irq, struct irq_desc *desc)
 #endif
 	remove_proc_entry("spurious", desc->dir);
 
-	memset(name, 0, MAX_NAMELEN);
 	sprintf(name, "%u", irq);
 	remove_proc_entry(name, root_irq_dir);
 }