perf trace: Beautify the umount's 'name' argument
tip-bot for Arnaldo Carvalho de Melo
merge botCommit-ID: 476c92cacf383c83584ba02d06c88cf18f062afb Gitweb: https://git.kernel.org/tip/476c92cacf383c83584ba02d06c88cf18f062afb Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Fri, 26 Oct 2018 13:23:25 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Tue, 30 Oct 2018 11:46:23 -0300
perf trace: Beautify the umount's 'name' argument
By using the SCA_FILENAME beautifier, that works when either the probe:vfs_getname probe is in place or with the eBPF program tools/perf/examples/bpf/augmented_syscalls.c:
# perf probe -l probe:vfs_getname (on getname_flags:73@acme/git/linux/fs/namei.c with pathname) # perf trace -e umount 9630.332 ( 9.521 ms): umount/8082 umount2(name: /mnt) = 0 #
The augmented syscalls one will be done in the next patch.
Cc Adrian Hunter <[email protected]>
Cc Benjamin Peterson <[email protected]>
Cc David Ahern <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Wang Nan <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/builtin-trace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/builtin-trace.c +2 -1
@@ -838,7 +838,8 @@ static struct syscall_fmt { .arg = { [2] = { .scnprintf = SCA_SIGNUM, /* sig */ }, }, }, { .name = "tkill", .arg = { [1] = { .scnprintf = SCA_SIGNUM, /* sig */ }, }, }, - { .name = "umount2", .alias = "umount", }, + { .name = "umount2", .alias = "umount", + .arg = { [0] = { .scnprintf = SCA_FILENAME, /* name */ }, }, }, { .name = "uname", .alias = "newuname", }, { .name = "unlinkat", .arg = { [0] = { .scnprintf = SCA_FDAT, /* dfd */ }, }, },