Skip to contentSkip to conversation

perf kmem: Fix compiler warning about may be accessing uninitialized variable

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message May 15, 2015 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  08a9b9857fc2d77600f09f3d342f6c64d25083b2
Gitweb:     http://git.kernel.org/tip/08a9b9857fc2d77600f09f3d342f6c64d25083b2
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Mon, 11 May 2015 11:41:17 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 12 May 2015 09:59:47 -0300

perf kmem: Fix compiler warning about may be accessing uninitialized variable

The last argument to strtok_r doesn't need to be initialized, its just a placeholder to make this routine reentrant, but gcc doesn't know about that and complains, breaking the build, fix it by setting it to NULL.

Fixes 0e11115644b3 ("perf kmem: Print gfp flags in human readable string")
Cc Adrian Hunter <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc David Ahern <[email protected]>
Cc Don Zickus <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Stephane Eranian <[email protected]>
---
 tools/perf/builtin-kmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-kmem.c +1 -1
index e0173c7..254614b 100644
@@ -713,7 +713,7 @@ static int parse_gfp_flags(struct perf_evsel *evsel, struct perf_sample *sample,
 		.size = sample->raw_size,
 	};
 	struct trace_seq seq;
-	char *str, *pos;
+	char *str, *pos = NULL;
 
 	if (nr_gfps) {
 		struct gfp_flag key = {