Skip to contentSkip to conversation

perf strlist: load() should return a negative errno

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Jul 21, 2015 perf events

lore
Share & tools
lore

tip-bot for Arnaldo Carvalho de Melo

author merge bot
#0 lore raw
Commit-ID:  ab7322af8c620987ed058e39506c97e5f2d3c65c
Gitweb:     http://git.kernel.org/tip/ab7322af8c620987ed058e39506c97e5f2d3c65c
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 16 Jul 2015 11:08:34 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 16 Jul 2015 11:08:34 -0300

perf strlist: load() should return a negative errno

To match what its users return.

Cc Adrian Hunter <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Stephane Eranian <[email protected]>
Link http://lkml.kernel.org/n/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/util/strlist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/strlist.c +1 -1
index 71f9d10..68ae673 100644
@@ -72,7 +72,7 @@ int strlist__load(struct strlist *slist, const char *filename)
 	FILE *fp = fopen(filename, "r");
 
 	if (fp == NULL)
-		return errno;
+		return -errno;
 
 	while (fgets(entry, sizeof(entry), fp) != NULL) {
 		const size_t len = strlen(entry);