Skip to contentSkip to conversation

perf top: Don' t update total_period on process_sample

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Jan 8, 2012 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  df25f989a4390ca0dbc9cb24516d4b10c01ceda8
Gitweb:     http://git.kernel.org/tip/df25f989a4390ca0dbc9cb24516d4b10c01ceda8
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 5 Jan 2012 12:21:08 -0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Fri, 6 Jan 2012 15:46:50 -0200

perf top: Don't update total_period on process_sample

It will be recalculated at __hists__output_resort, to take into account filters possibly applied by the TUI, etc.

Since we do the percent math only for those entries that will appear on the TUI instead of for _all_ the entries at decay time, updating it for each sample makes the entries seem to decay faster when using the navigation keys (since the screen will be refreshed), as we're not coalescing the entries that are being batched to be merged at next resort/decay time, but considering their periods.

Bug introduced in 743eb86.

---
 tools/perf/builtin-top.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
tools/perf/builtin-top.c +0 -1
index 4f81eeb..d89dec9 100644
@@ -235,7 +235,6 @@ static struct hist_entry *perf_evsel__add_hist_entry(struct perf_evsel *evsel,
 	if (he == NULL)
 		return NULL;
 
-	evsel->hists.stats.total_period += sample->period;
 	hists__inc_nr_events(&evsel->hists, PERF_RECORD_SAMPLE);
 	return he;
 }