Skip to contentSkip to conversation

perf report: Remove duplicated 'samples' in lost samples warning

tip:perf/urgent tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Apr 6, 2018 perf events

lore
Share & tools
lore

tip-bot for Arnaldo Carvalho de Melo

author merge bot
#0 lore raw
Commit-ID:  41a43dacecdbc9aec9d307bd9f6aa5ec16d65832
Gitweb:     https://git.kernel.org/tip/41a43dacecdbc9aec9d307bd9f6aa5ec16d65832
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 5 Apr 2018 14:34:09 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 5 Apr 2018 14:34:09 -0300

perf report: Remove duplicated 'samples' in lost samples warning

The following message, emitted when samples are lost due to system overload, had one 'samples' too many, ditch it:

Processed 25333 samples and lost 20.88% samples!

Cc Adrian Hunter <[email protected]>
Cc David Ahern <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Wang Nan <[email protected]>
Cc Kan Liang <[email protected]>
Link https://lkml.kernel.org/n/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/util/session.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/session.c +1 -1
index c71ced7db152..f4a7a437ee87 100644
@@ -1591,7 +1591,7 @@ static void perf_session__warn_about_errors(const struct perf_session *session)
 		drop_rate = (double)stats->total_lost_samples /
 			    (double) (stats->nr_events[PERF_RECORD_SAMPLE] + stats->total_lost_samples);
 		if (drop_rate > 0.05) {
-			ui__warning("Processed %" PRIu64 " samples and lost %3.2f%% samples!\n\n",
+			ui__warning("Processed %" PRIu64 " samples and lost %3.2f%%!\n\n",
 				    stats->nr_events[PERF_RECORD_SAMPLE] + stats->total_lost_samples,
 				    drop_rate * 100.0);
 		}