perf report/top: Make 'e' visible in the help and make it toggle showing callchains
A message that is not in the archive (sent off-list or not yet received): [email protected]
The following commit has been merged into the perf/core branch of tip:
Commit-ID: e6d6abfc447a65e949c1e883e66e1450903d2fbd Gitweb: https://git.kernel.org/tip/e6d6abfc447a65e949c1e883e66e1450903d2fbd Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Tue, 17 Dec 2019 10:39:04 -03:00 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitterDate: Mon, 06 Jan 2020 11:46:10 -03:00
perf report/top: Make 'e' visible in the help and make it toggle showing callchains
The 'e' and 'c' hotkeys were present for a long time, but not documented in the help window, change 'e' to be a toggle so that it gets consistent with other toggles like '+' and document it in the help window.
Keep 'c' as is for people used to it but don't document, as it is easier to just use 'e' to show/hide all the callchains for a top level histogram entry.
Reviewed-by Jiri Olsa <[email protected]>
Cc Adrian Hunter <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Jin Yao <[email protected]>
Cc Kan Liang <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Namhyung Kim <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/ui/browsers/hists.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
tools/perf/ui/browsers/hists.c +7 -1
@@ -407,6 +407,11 @@ static bool hist_browser__selection_has_children(struct hist_browser *browser) return container_of(ms, struct callchain_list, ms)->has_children; } +static bool hist_browser__he_selection_unfolded (struct hist_browser *browser) +{ +return browser->he_selection ? browser->he_selection->unfolded : false; +} +static bool hist_browser__selection_unfolded (struct hist_browser *browser) {struct hist_entry *he = browser->he_selection;
@@ -727,7 +732,7 @@ static int hist_browser__handle_hotkey(struct hist_browser *browser, bool warn_lbreak ;case 'e' :/* Expand the selected entry. */ -hist_browser__set_folding_selected (browser, true); +hist_browser__set_folding_selected (browser, !hist_browser__he_selection_unfolded (browser));break ;case 'H' : browser->show_headers = !browser->show_headers;
@@ -2942,6 +2947,7 @@ static int perf_evsel__hists_browse(struct evsel *evsel, int nr_events,"a Annotate current symbol\n" \"C Collapse all callchains\n" \"d Zoom into current DSO\n" \ +"e Expand/Collapse main entry callchains\n" \"E Expand all callchains\n" \"F Toggle percentage of filtered entries\n" \"H Display column headers\n" \