perf ui tui progress: Implement the ui_progress_ops->finish() method
tip-bot for Arnaldo Carvalho de Melo
merge botCommit-ID: 1e259ad4a25e37eb298bb5772b9a51e70bed7782 Gitweb: http://git.kernel.org/tip/1e259ad4a25e37eb298bb5772b9a51e70bed7782 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Mon, 24 Aug 2015 16:18:26 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 24 Aug 2015 16:18:26 -0300
perf ui tui progress: Implement the ui_progress_ops->finish() method
So that we can erase the progress bar after we're done with it, avoiding things like:
-------------------------------------------------------------------
┌─Error:──────────────────────────────────────────────────────┐
│Can't annotate unmapped_area_topdown: │
│ │
│No vmlinux file with build id a826726b5ddacfab1f0bade868f1a79│
│was found in the path. │
│ │
│Note that annotation using /proc/kcore requires CAP_SYS_RAWIO│
┌Processin│ │──┐
│ │Please use: │ │
└─────────│ │──┘
│ perf buildid-cache -vu vmlinux │
│ │
│or: │
│ │
│ --vmlinux vmlinux │
│ │
│ │
│Press any key... │
└─────────────────────────────────────────────────────────────┘Can't annotate unmapped_area_topdown:
-------------------------------------------------------------------
I.e. that finished progress bar behind the error window. It is not a problem when we end up redrawing the whole screen, but its ugly when we present such error windows, provide a TUI method so that code like the above may avoid this situation, as will be done with the annotation code in the next cset.
Cc Adrian Hunter <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Stephane Eranian <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/ui/tui/progress.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)
tools/perf/ui/tui/progress.c +18 -1
@@ -33,9 +33,26 @@ static void tui_progress__update(struct ui_progress *p)pthread_mutex_unlock (&ui__lock); } +static void tui_progress__finish (void ) +{ +int y; + +if (use_browser <=0 ) +return ; + +ui__refresh_dimensions (false); +pthread_mutex_lock (&ui__lock); + y = SLtt_Screen_Rows /2 -2 ; +SLsmg_set_color (0 ); +SLsmg_fill_region (y,0 ,3 , SLtt_Screen_Cols,' ' ); +SLsmg_refresh (); +pthread_mutex_unlock (&ui__lock); +} +static struct ui_progress_ops tui_progress__ops = { - .update = tui_progress__update, + .update = tui_progress__update, + .finish = tui_progress__finish, };void tui_progress__init (void )