perf tools: Move timestamp routines from util.h to time-utils.h
tip-bot for Arnaldo Carvalho de Melo
merge botCommit-ID: c5e4027e056c3027f682f0d69fe9fd75083b65f8 Gitweb: http://git.kernel.org/tip/c5e4027e056c3027f682f0d69fe9fd75083b65f8 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Wed, 19 Apr 2017 16:12:39 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Thu, 20 Apr 2017 13:22:44 -0300
perf tools: Move timestamp routines from util.h to time-utils.h
We already have a header for time utilities, so use it.
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/builtin-buildid-cache.c | 1 + tools/perf/builtin-kvm.c | 1 + tools/perf/builtin-record.c | 1 + tools/perf/util/time-utils.c | 25 +++++++++++++++++++++++++ tools/perf/util/time-utils.h | 7 +++++++ tools/perf/util/util.c | 25 ------------------------- tools/perf/util/util.h | 6 ------ 7 files changed, 35 insertions(+), 31 deletions(-)
tools/perf/builtin-buildid-cache.c +1 -0
@@ -22,6 +22,7 @@#include "util/build-id.h" #include "util/session.h" #include "util/symbol.h" +#include "util/time-utils.h" static int build_id_cache__kcore_buildid (const char *proc_dir,char *sbuildid) {
tools/perf/builtin-kvm.c +1 -0
@@ -24,6 +24,7 @@#ifdef HAVE_TIMERFD_SUPPORT #include <sys/timerfd.h> #endif +#include <sys/time.h> #include <linux/kernel.h> #include <linux/time64.h>
tools/perf/builtin-record.c +1 -0
@@ -38,6 +38,7 @@#include "util/bpf-loader.h" #include "util/trigger.h" #include "util/perf-hooks.h" +#include "util/time-utils.h" #include "util/units.h" #include "asm/bug.h"
tools/perf/util/time-utils.c +25 -0
@@ -117,3 +117,28 @@ bool perf_time__skip_sample(struct perf_time_interval *ptime, u64 timestamp)return false; } + +int timestamp__scnprintf_usec (u64 timestamp,char *buf,size_t sz) +{ +u64 sec = timestamp /NSEC_PER_SEC ; +u64 usec = (timestamp %NSEC_PER_SEC ) /NSEC_PER_USEC ; + +return scnprintf (buf, sz,"%" PRIu64".%06" PRIu64, sec, usec); +} + +int fetch_current_timestamp (char *buf,size_t sz) +{ +struct timeval tv; +struct tm tm; +char dt[32 ]; + +if (gettimeofday (&tv,NULL ) || !localtime_r (&tv.tv_sec, &tm)) +return -1 ; + +if (!strftime (dt,sizeof (dt),"%Y%m%d%H%M%S" , &tm)) +return -1 ; + +scnprintf (buf, sz,"%s%02u" , dt, (unsigned )tv.tv_usec /10000 ); + +return 0 ; +}
tools/perf/util/time-utils.h +7 -0
@@ -1,6 +1,9 @@#ifndef _TIME_UTILS_H_#define _TIME_UTILS_H_ +#include <stddef.h> +#include <linux/types.h> +struct perf_time_interval {u64 start, end; };
@@ -11,4 +14,8 @@ int perf_time__parse_str(struct perf_time_interval *ptime, const char *ostr);bool perf_time__skip_sample (struct perf_time_interval *ptime,u64 timestamp); +int timestamp__scnprintf_usec (u64 timestamp,char *buf,size_t sz); + +int fetch_current_timestamp (char *buf,size_t sz); +#endif
tools/perf/util/util.c +0 -25
@@ -381,14 +381,6 @@ void sighandler_dump_stack(int sig)raise (sig); } -int timestamp__scnprintf_usec (u64 timestamp,char *buf,size_t sz) -{ -u64 sec = timestamp /NSEC_PER_SEC ; -u64 usec = (timestamp %NSEC_PER_SEC ) /NSEC_PER_USEC ; - -return scnprintf (buf, sz,"%" PRIu64".%06" PRIu64, sec, usec); -} -unsigned long parse_tag_value (const char *str,struct parse_tag *tags) {struct parse_tag *i = tags;
@@ -692,20 +684,3 @@ out:return tip; } - -int fetch_current_timestamp (char *buf,size_t sz) -{ -struct timeval tv; -struct tm tm; -char dt[32 ]; - -if (gettimeofday (&tv,NULL ) || !localtime_r (&tv.tv_sec, &tm)) -return -1 ; - -if (!strftime (dt,sizeof (dt),"%Y%m%d%H%M%S" , &tm)) -return -1 ; - -scnprintf (buf, sz,"%s%02u" , dt, (unsigned )tv.tv_usec /10000 ); - -return 0 ; -}
tools/perf/util/util.h +0 -6
@@ -20,10 +20,7 @@#include <limits.h> #include <sys/param.h> #include <sys/types.h> -#include <sys/time.h> -#include <time.h> #include <assert.h> -#include <utime.h> #include <sys/wait.h> #include <poll.h> #include <sys/socket.h>
@@ -125,12 +122,9 @@ int fetch_kernel_version(unsigned int *puint,#define KVER_PARAM (x) KVER_VERSION(x), KVER_PATCHLEVEL(x), KVER_SUBLEVEL(x)const char *perf_tip (const char *dirpath); -int fetch_current_timestamp (char *buf,size_t sz);#ifndef HAVE_SCHED_GETCPU_SUPPORT int sched_getcpu (void );#endif -int timestamp__scnprintf_usec (u64 timestamp,char *buf,size_t sz); -#endif /* GIT_COMPAT_UTIL_H */