Skip to contentSkip to conversation

perf tools: Add warning when disabling perl scripting support due to missing devel files

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Jun 5, 2014 perf events

lore
Share & tools
lore

tip-bot for Arnaldo Carvalho de Melo

author merge bot
#0 lore raw
Commit-ID:  6a2f2543a1f3aa0e7766e27c30b93d164771e892
Gitweb:     http://git.kernel.org/tip/6a2f2543a1f3aa0e7766e27c30b93d164771e892
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Mon, 26 May 2014 16:02:30 -0300
Committer:  Jiri Olsa <[email protected]>
CommitDate: Tue, 3 Jun 2014 21:34:16 +0200

perf tools: Add warning when disabling perl scripting support due to missing devel files

We were just showing "libperl: OFF", unlike other features where we present the user with a message helping have a feature built in.

Fix it by adding the following message:

config/Makefile:450: Missing perl devel files. Disabling perl scripting support, consider installing perl-ExtUtils-Embed

Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Cc Adrian Hunter <[email protected]>
Cc David Ahern <[email protected]>
Cc Don Zickus <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
Link http://lkml.kernel.org/n/[email protected] open here
Signed-off-by Jiri Olsa <[email protected]>
---
 tools/perf/config/Makefile | 1 +
 1 file changed, 1 insertion(+)
tools/perf/config/Makefile +1 -0
index 729bbdf..319426f 100644
@@ -447,6 +447,7 @@ else
   ifneq ($(feature-libperl), 1)
     CFLAGS += -DNO_LIBPERL
     NO_LIBPERL := 1
+    msg := $(warning Missing perl devel files. Disabling perl scripting support, consider installing perl-ExtUtils-Embed);
   else
     LDFLAGS += $(PERL_EMBED_LDFLAGS)
     EXTLIBS += $(PERL_EMBED_LIBADD)