perf annotate stdio2: Print more descriptive event information header
tip-bot for Arnaldo Carvalho de Melo
merge botCommit-ID: 520d3f01ea5322edeedff4bb25a0aff07ad72d43 Gitweb: https://git.kernel.org/tip/520d3f01ea5322edeedff4bb25a0aff07ad72d43 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Mon, 2 Apr 2018 16:42:01 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Tue, 3 Apr 2018 16:05:13 -0300
perf annotate stdio2: Print more descriptive event information header
To match the recently added event header information to --tui, e.g.:
# perf annotate --ignore-vmlinux --stdio2 _raw_spin_lock_irqsave
Samples: 128 of event 'cycles:ppp', 4000 Hz, Event count (approx.): 48617682
_raw_spin_lock_irqsave() /proc/kcore
0.78 nop
7.03 push %rbx
3.12 pushfq
6.25 pop %rax
nop
mov %rax,%rbx
3.12 cli
nop
xor %eax,%eax
mov $0x1,%edx
79.69 lock cmpxchg %edx,(%rdi)
test %eax,%eax
↓ jne 2b
mov %rbx,%rax
pop %rbx
← retq
2b: mov %eax,%esi
→ callq *ffffffffb30eaed0
mov %rbx,%rax
pop %rbx
← retq
#Cc Adrian Hunter <[email protected]>
Cc David Ahern <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Martin Liška <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Wang Nan <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/annotate.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
tools/perf/util/annotate.c +3 -7
@@ -2325,7 +2325,7 @@ int symbol__tty_annotate2(struct symbol *sym, struct map *map,struct dso *dso = map->dso;struct rb_root source_line =RB_ROOT ;struct annotation_options opts = annotation__default_options; -const char *ev_name =perf_evsel__name (evsel); +struct annotation *notes =symbol__annotation (sym);char buf[1024 ];if (symbol__annotate2 (sym, map, evsel, &opts,NULL ) <0 )
@@ -2337,12 +2337,8 @@ int symbol__tty_annotate2(struct symbol *sym, struct map *map,print_summary (&source_line, dso->long_name); } -if (perf_evsel__is_group_event (evsel)) { -perf_evsel__group_desc (evsel, buf,sizeof (buf)); - ev_name = buf; - } - -fprintf (stdout,"%s() %s\nEvent: %s\n\n" , sym->name, dso->long_name, ev_name); +annotation__scnprintf_samples_period (notes, buf,sizeof (buf), evsel); +fprintf (stdout,"%s\n%s() %s\n" , buf, sym->name, dso->long_name);symbol__annotate_fprintf2 (sym, stdout);annotated_source__purge (symbol__annotation (sym)->src);