Skip to contentSkip to conversation

perf trace: Support --events foo: bar --no-syscalls

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Feb 18, 2015 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  726f3234dd125633438922a07a80f933f13daf82
Gitweb:     http://git.kernel.org/tip/726f3234dd125633438922a07a80f933f13daf82
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Fri, 6 Feb 2015 10:16:45 +0100
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Fri, 13 Feb 2015 17:30:29 -0300

perf trace: Support --events foo:bar --no-syscalls

I.e. support tracing just tracepoints, without strace like raw_syscalls:*.

[acme@ssdandy linux]$ trace --no-sys --ev sched:*exec,sched:*switch,sched:*exit usleep 1

  0.048 (     ): sched:sched_process_exec:filename=/usr/bin/usleep pid=27298 old_pid=27298)
  0.369 (     ): sched:sched_switch:usleep:27298 [120] S ==> swapper/5:0 [120])
  0.452 (     ): sched:sched_process_exit:comm=usleep pid=27298 prio=120)

[acme@ssdandy linux]$

TODO: remove that (...) thing when --no-syscalls is specified.

Cc Adrian Hunter <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc David Ahern <[email protected]>
Cc Don Zickus <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
---
 tools/perf/builtin-trace.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/builtin-trace.c +2 -1
index a44ac93..b1c1df9 100644
@@ -2625,7 +2625,8 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused)
 	if (trace.summary_only)
 		trace.summary = trace.summary_only;
 
-	if (!trace.trace_syscalls && !trace.trace_pgfaults) {
+	if (!trace.trace_syscalls && !trace.trace_pgfaults &&
+	    trace.evlist->nr_entries == 0 /* Was --events used? */) {
 		pr_err("Please specify something to trace.\n");
 		return -1;
 	}