Skip to contentSkip to conversation

tools strfilter: Use __fallthrough

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Feb 10, 2017 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  d64b721d27aef3fbeb16ecda9dd22ee34818ff70
Gitweb:     http://git.kernel.org/tip/d64b721d27aef3fbeb16ecda9dd22ee34818ff70
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Wed, 8 Feb 2017 17:01:46 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 8 Feb 2017 17:31:10 -0300

tools strfilter: Use __fallthrough

The implicit fall through case label here is intended, so let us inform that to gcc >= 7:

util/strfilter.c: In function 'strfilter_node__sprint':
util/strfilter.c:270:6: error: this statement may fall through [-Werror=implicit-fallthrough=]

     if (len < 0)
        ^
  util/strfilter.c:272:2: note: here
    case '!':
    ^~~~

cc1: all warnings being treated as errors

---
 tools/perf/util/strfilter.c | 1 +
 1 file changed, 1 insertion(+)
tools/perf/util/strfilter.c +1 -0
index bcae659..efb5377 100644
@@ -269,6 +269,7 @@ static int strfilter_node__sprint(struct strfilter_node *node, char *buf)
 		len = strfilter_node__sprint_pt(node->l, buf);
 		if (len < 0)
 			return len;
+		__fallthrough;
 	case '!':
 		if (buf) {
 			*(buf + len++) = *node->p;