Skip to contentSkip to conversation

mm/mpol: Remove NUMA_INTERLEAVE_HIT

tip:sched/numa tip-bot for Peter Zijlstra 1 participant 1 message Sep 27, 2012

Subsystems (5)
lore
Share & tools
lore
#0 lore raw
Commit-ID:  ab1c81726ad908c4e8d6c48f298c36783507c95e
Gitweb:     http://git.kernel.org/tip/ab1c81726ad908c4e8d6c48f298c36783507c95e
Author:     Peter Zijlstra <[email protected]>
AuthorDate: Thu, 12 Jan 2012 16:07:00 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 26 Sep 2012 11:48:30 +0200

mm/mpol: Remove NUMA_INTERLEAVE_HIT

Since the NUMA_INTERLEAVE_HIT statistic is useless on its own; it wants to be compared to either a total of interleave allocations or to a miss count, remove it.

Fixing it would be possible, but since we've gone years without these statistics I figure we can continue that way.

Also NUMA_HIT fully includes NUMA_INTERLEAVE_HIT so users might switch to using that.

This cleans up some of the weird MPOL_INTERLEAVE allocation exceptions.

---
 drivers/base/node.c    |    2 +-
 include/linux/mmzone.h |    1 -
 mm/mempolicy.c         |   68 +++++++++++++++---------------------------------
 mm/vmstat.c            |    1 -
 4 files changed, 22 insertions(+), 50 deletions(-)
drivers/base/node.c +1 -1
index af1a177..ef51157 100644
@@ -169,7 +169,7 @@ static ssize_t node_read_numastat(struct device *dev,
 		       node_page_state(dev->id, NUMA_HIT),
 		       node_page_state(dev->id, NUMA_MISS),
 		       node_page_state(dev->id, NUMA_FOREIGN),
-		       node_page_state(dev->id, NUMA_INTERLEAVE_HIT),
+		       0UL,
 		       node_page_state(dev->id, NUMA_LOCAL),
 		       node_page_state(dev->id, NUMA_OTHER));
 }
include/linux/mmzone.h +0 -1
index 2daa54f..f222e06 100644
@@ -137,7 +137,6 @@ enum zone_stat_item {
 	NUMA_HIT,		/* allocated in intended node */
 	NUMA_MISS,		/* allocated in non intended node */
 	NUMA_FOREIGN,		/* was intended here, hit elsewhere */
-	NUMA_INTERLEAVE_HIT,	/* interleaver preferred this zone */
 	NUMA_LOCAL,		/* allocation from local node */
 	NUMA_OTHER,		/* allocation from other node */
 #endif
mm/mempolicy.c +21 -47

103 lines not on this page · raw message

mm/vmstat.c +0 -1
index df7a674..dcc3858 100644
@@ -717,7 +717,6 @@ const char * const vmstat_text[] = {
 	"numa_hit",
 	"numa_miss",
 	"numa_foreign",
-	"numa_interleave",
 	"numa_local",
 	"numa_other",
 #endif