Skip to contentSkip to conversation

sched/numa: Don't scale the imbalance

tip:sched/core tip-bot for Peter Zijlstra 1 participant 1 message May 14, 2012 Scheduler

lore
Share & tools
lore
#0 lore raw
Commit-ID:  870a0bb5d636156502769233d02a0d5791d4366a
Gitweb:     http://git.kernel.org/tip/870a0bb5d636156502769233d02a0d5791d4366a
Author:     Peter Zijlstra <[email protected]>
AuthorDate: Fri, 11 May 2012 00:26:27 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 14 May 2012 15:05:26 +0200

sched/numa: Don't scale the imbalance

It's far too easy to get ridiculously large imbalance pct when you scale it like that. Use a fixed 125% for now.

---
 kernel/sched/core.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
kernel/sched/core.c +1 -6
index 24922b7..6883d99 100644
@@ -6261,11 +6261,6 @@ static int *sched_domains_numa_distance;
 static struct cpumask ***sched_domains_numa_masks;
 static int sched_domains_curr_level;
 
-static inline unsigned long numa_scale(unsigned long x, int level)
-{
-	return x * sched_domains_numa_distance[level] / sched_domains_numa_scale;
-}
-
 static inline int sd_local_flags(int level)
 {
 	if (sched_domains_numa_distance[level] > REMOTE_DISTANCE)
@@ -6286,7 +6281,7 @@ sd_numa_init(struct sched_domain_topology_level *tl, int cpu)
 		.min_interval		= sd_weight,
 		.max_interval		= 2*sd_weight,
 		.busy_factor		= 32,
-		.imbalance_pct		= 100 + numa_scale(25, level),
+		.imbalance_pct		= 125,
 		.cache_nice_tries	= 2,
 		.busy_idx		= 3,
 		.idle_idx		= 2,