ieee1394: sbp2: slightly reorder sbp2scsi_abort
PATCH 1/1 ieee1394: sbp2: slightly reorder sbp2scsi_abort
Put the target's fetch agent into reset state before the underlying ORB DMA is unmapped and the ->done handler is called. It is highly unlikely but the target could access that ORB right before sbp2 sends the reset request.
Signed-off-by Stefan Richter <[email protected]>
---
drivers/ieee1394/sbp2.c +2 -8
@@ -2560,11 +2560,9 @@ static int sbp2scsi_abort(struct scsi_cmscsi_print_command (SCpnt);if (sbp2util_node_is_available (scsi_id)) { +sbp2_agent_reset (scsi_id,1 ); -/* -* Right now, just return any matching command structures -* to the free pool. -*/ +/* Return a matching command structure to the free pool. */ spin_lock_irqsave (&scsi_id->sbp2_command_orb_lock, flags); command =sbp2util_find_command_for_SCpnt (scsi_id, SCpnt);if (command) {
@@ -2585,10 +2583,6 @@ static int sbp2scsi_abort(struct scsi_cm }spin_unlock_irqrestore (&scsi_id->sbp2_command_orb_lock, flags); -/* -* Initiate a fetch agent reset. -*/ -sbp2_agent_reset (scsi_id,1 );sbp2scsi_complete_all_commands (scsi_id,DID_BUS_BUSY ); }
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642