Skip to contentSkip to conversation

ieee1394: remove superfluous assertions

PATCH New Stefan Richter 1 participant 1 message Feb 16, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ieee1394: remove superfluous assertions

hpsb_read, hpsb_write, hpsb_lock are sleeping functions which nobody is in danger to use in atomic context. Besides, in_interrupt does not cover all types of atomic context.

---
 drivers/ieee1394/ieee1394_transactions.c |    6 ------
 1 file changed, 6 deletions(-)
drivers/ieee1394/ieee1394_transactions.c +0 -6
Index: linux/drivers/ieee1394/ieee1394_transactions.c
===================================================================
@@ -501,8 +501,6 @@ int hpsb_read(struct hpsb_host *host, no
 	if (length == 0)
 		return -EINVAL;
 
-	BUG_ON(in_interrupt());	// We can't be called in an interrupt, yet
-
 	packet = hpsb_make_readpacket(host, node, addr, length);
 
 	if (!packet) {
@@ -550,8 +548,6 @@ int hpsb_write(struct hpsb_host *host, n
 	if (length == 0)
 		return -EINVAL;
 
-	BUG_ON(in_interrupt());	// We can't be called in an interrupt, yet
-
 	packet = hpsb_make_writepacket(host, node, addr, buffer, length);
 
 	if (!packet)
@@ -577,8 +573,6 @@ int hpsb_lock(struct hpsb_host *host, no
 	struct hpsb_packet *packet;
 	int retval = 0;
 
-	BUG_ON(in_interrupt());
-
 	packet = hpsb_make_lockpacket(host, node, addr, extcode, data, arg);
 	if (!packet)
 		return -ENOMEM;
Signature · 3 lines
Stefan Richter
-=====-==--= --=- =----
http://arcgraph.de/sr/