firewire: sbp2: fix freeing of unallocated memory
PATCH 1/1 firewire: sbp2: fix freeing of unallocated memory
If a target writes invalid status (typically status of a command that already timed out, firewire-sbp2 attempts to put away an ORB that doesn't exist. https://bugzilla.redhat.com/show_bug.cgi?id=519772
Signed-off-by Stefan Richter <[email protected]>
--- drivers/firewire/sbp2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/firewire/sbp2.c +4 -4
@@ -456,12 +456,12 @@ static void sbp2_status_write(struct fw_ }spin_unlock_irqrestore (&card->lock, flags); -if (&orb->link != &lu->orb_list) +if (&orb->link != &lu->orb_list) { orb->callback (orb, &status); -else +kref_put (&orb->kref, free_orb); + }else {fw_error ("status write for unknown orb\n" ); - -kref_put (&orb->kref, free_orb); + }fw_send_response (card, request,RCODE_COMPLETE ); }
Signature · 3 lines
Stefan Richter -=====-==--= =--= ---== http://arcgraph.de/sr/