firewire: core: fix crash in iso resource management
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 firewire: core: fix crash in iso resource management
This fixes a regression due to post 2.6.30 commit "firewire: core: do not DMA-map stack addresses" 6fdc03709433ccc2005f0f593ae9d9dd04f7b485.
As David Moore noted, a previously correct sizeof() expression became wrong since the commit changed its argument from an array to a pointer. This resulted in an oops in ohci_cancel_packet in the shared workqueue thread's context when an isochronous resource was to be freed.
--- drivers/firewire/core-card.c | 2 ++ drivers/firewire/core-iso.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/firewire/core-iso.c +2 -2
@@ -196,7 +196,7 @@ static int manage_bandwidth(struct fw_caswitch (fw_run_transaction (card,TCODE_LOCK_COMPARE_SWAP , irm_id, generation,SCODE_100 ,CSR_REGISTER_BASE +CSR_BANDWIDTH_AVAILABLE , - data,sizeof (data))) { + data,8 )) {case RCODE_GENERATION :/* A generation change frees all bandwidth. */ return allocate ? -EAGAIN : bandwidth;
@@ -233,7 +233,7 @@ static int manage_channel(struct fw_card data[1 ] = old ^ c;switch (fw_run_transaction (card,TCODE_LOCK_COMPARE_SWAP , irm_id, generation,SCODE_100 , - offset, data,sizeof (data))) { + offset, data,8 )) {case RCODE_GENERATION :/* A generation change frees all channels. */ return allocate ? -EAGAIN : i;
Signature · 3 lines
Stefan Richter -=====-==--= =--= --=-= http://arcgraph.de/sr/