Skip to contentSkip to conversation

firewire: fix small memory leak at module removal

PATCH New Stefan Richter 1 participant 1 message Nov 24, 2008 Firewire

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firewire: fix small memory leak at module removal

---
 drivers/firewire/fw-device.c      |    2 +-
 drivers/firewire/fw-device.h      |    2 ++
 drivers/firewire/fw-transaction.c |    2 ++
 3 files changed, 5 insertions(+), 1 deletion(-)
drivers/firewire/fw-device.c +1 -1
Index: linux/drivers/firewire/fw-device.c
===================================================================
@@ -619,7 +619,7 @@ static int shutdown_unit(struct device *
  */
 DECLARE_RWSEM(fw_device_rwsem);
 
-static DEFINE_IDR(fw_device_idr);
+DEFINE_IDR(fw_device_idr);
 int fw_cdev_major;
 
 struct fw_device *fw_device_get_by_devt(dev_t devt)
drivers/firewire/fw-device.h +2 -0
Index: linux/drivers/firewire/fw-device.h
===================================================================
@@ -21,6 +21,7 @@
 
 #include <linux/fs.h>
 #include <linux/cdev.h>
+#include <linux/idr.h>
 #include <linux/rwsem.h>
 #include <linux/mutex.h>
 #include <asm/atomic.h>
@@ -103,6 +104,7 @@ void fw_device_cdev_update(struct fw_dev
 void fw_device_cdev_remove(struct fw_device *device);
 
 extern struct rw_semaphore fw_device_rwsem;
+extern struct idr fw_device_idr;
 extern int fw_cdev_major;
 
 /*
drivers/firewire/fw-transaction.c +2 -0
Index: linux/drivers/firewire/fw-transaction.c
===================================================================
@@ -19,6 +19,7 @@
  */
 
 #include <linux/completion.h>
+#include <linux/idr.h>
 #include <linux/kernel.h>
 #include <linux/kref.h>
 #include <linux/module.h>
@@ -968,6 +969,7 @@ static void __exit fw_core_cleanup(void)
 {
 	unregister_chrdev(fw_cdev_major, "firewire");
 	bus_unregister(&fw_bus_type);
+	idr_destroy(&fw_device_idr);
 }
 
 module_init(fw_core_init);
Signature · 3 lines
Stefan Richter
-=====-==--- =-== ==---
http://arcgraph.de/sr/