Skip to contentSkip to conversation

firewire: fix unloading of fw-ohci while devices are attached

PATCH New Stefan Richter 1 participant 1 message Oct 10, 2007 Firewire

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firewire: fix unloading of fw-ohci while devices are attached

Fix panic in run_timer_softirq right after "modprobe -r firewire-ohci" if a FireWire disk was attached and firewire-sbp2 loaded.

Same as commit 8a2d9ed3210464d22fccb9834970629c1c36fa36.

---

(I somehow forgot to send this earlier.)

 drivers/firewire/fw-card.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/firewire/fw-card.c +4 -2
Index: linux-2.6.22.10/drivers/firewire/fw-card.c
===================================================================
@@ -507,9 +507,11 @@ fw_core_remove_card(struct fw_card *card
 	/* Set up the dummy driver. */
 	card->driver = &dummy_driver;
 
-	fw_flush_transactions(card);
-
 	fw_destroy_nodes(card);
+	flush_scheduled_work();
+
+	fw_flush_transactions(card);
+	del_timer_sync(&card->flush_timer);
 
 	fw_card_put(card);
 }
Signature · 3 lines
Stefan Richter
-=====-=-=== =-=- -=-=-
http://arcgraph.de/sr/