Skip to contentSkip to conversation

firewire: ohci: change "context_stop: still active" log message

PATCH New Stefan Richter 1 participant 1 message Jan 5, 2009 Firewire

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firewire: ohci: change "context_stop: still active" log message

The present message is mostly just noise. We only need to be notified if the "active" flag does not go off before the retry loop terminates.

---
 drivers/firewire/fw-ohci.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/firewire/fw-ohci.c +2 -2
Index: linux/drivers/firewire/fw-ohci.c
===================================================================
@@ -892,11 +892,11 @@ static void context_stop(struct context 
 	for (i = 0; i < 10; i++) {
 		reg = reg_read(ctx->ohci, CONTROL_SET(ctx->regs));
 		if ((reg & CONTEXT_ACTIVE) == 0)
-			break;
+			return;
 
-		fw_notify("context_stop: still active (0x%08x)\n", reg);
 		mdelay(1);
 	}
+	fw_error("Error: DMA context still active (0x%08x)\n", reg);
 }
 
 struct driver_data {
Signature · 3 lines
Stefan Richter
-=====-==--= ---= --=-=
http://arcgraph.de/sr/