Skip to contentSkip to conversation

ieee1394: revert "sbp2: enforce 32bit DMA mapping"

PATCH New Stefan Richter 1 participant 1 message Aug 4, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ieee1394: revert "sbp2: enforce 32bit DMA mapping"

Date: Wed, 1 Aug 2007 20:30:36 +0200 (CEST)
From: Stefan Richter <[email protected]>
Subject: ieee1394: revert "sbp2: enforce 32bit DMA mapping"

Revert commit 0555659d63c285ceb7ead3115532e1b71b0f27a7 from 2.6.22-rc1. The dma_set_mask call somehow failed on a PowerMac G5, PPC64:
http://lkml.org/lkml/2007/8/1/344

Should there ever occur a DMA mapping beyond the physical DMA range, a proper SBP-2 firmware will report transport errors. So let's leave it at that.

---
Same as commit a9c2f18800753c82c45fc13b27bdc148849bdbb2.

 drivers/ieee1394/sbp2.c |    5 -----
 1 file changed, 5 deletions(-)
drivers/ieee1394/sbp2.c +0 -5
Index: linux-2.6.22/drivers/ieee1394/sbp2.c
===================================================================
@@ -774,11 +774,6 @@ static struct sbp2_lu *sbp2_alloc_device
 			SBP2_ERR("failed to register lower 4GB address range");
 			goto failed_alloc;
 		}
-#else
-		if (dma_set_mask(hi->host->device.parent, DMA_32BIT_MASK)) {
-			SBP2_ERR("failed to set 4GB DMA mask");
-			goto failed_alloc;
-		}
 #endif
 	}
 
Signature · 3 lines
Stefan Richter
-=====-=-=== =--- --=--
http://arcgraph.de/sr/