Updated patch for firedtv: dvb_frontend_info for FireDTV S2, fix "frequency limits undefined" error
A message that is not in the archive (sent off-list or not yet received): [email protected]
On 23 Feb, Beat Michel Liechti wrote at linux1394-devel:
Quoted 17 lines
drivers/media/dvb/firewire/firedtv-fe.c renamed from drivers/media/dvb/firewire/firedtv-fe.c.orig +11
-0@@ -203,6 +203,24 @@ void fdtv_frontend_init(struct firedtv *FE_CAN_QPSK ;break ; +case FIREDTV_DVB_S2 : + fi->type =FE_QPSK ; + + fi->frequency_min =950000 ; + fi->frequency_max =2150000 ; + fi->frequency_stepsize =125 ; + fi->symbol_rate_min =1000000 ; + fi->symbol_rate_max =40000000 ; + + fi->caps =FE_CAN_INVERSION_AUTO | + FE_CAN_FEC_1_2 |
drivers/media/dvb/firewire/firedtv-fe.c void fdtv_frontend_init(struct firedtv * · line 226
Quoted 10 lines
drivers/media/dvb/firewire/firedtv-fe.c renamed from drivers/media/dvb/firewire/firedtv-fe.c.orig +7
-0+FE_CAN_FEC_2_3 | +FE_CAN_FEC_3_4 | +FE_CAN_FEC_5_6 | +FE_CAN_FEC_7_8 | +FE_CAN_QPSK ; +break ; +case FIREDTV_DVB_C : fi->type =FE_QAM ;
I would prefer to make case FIREDTV_DVB_S2 the same as case FIREDTV_DVB_S --- i.e. switch FE_CAN_FEC_AUTO on too since the S2 firmwares are said to support it for standard definition channels. We can revisit this issue when S2API is going to be implemented in the driver.
Or does leaving this flag off make an actual difference for you?
*If* it really does something, then we can still combine the two case blocks into one, remove the flag from fi->caps = ..., and add
if (fdtv->type = FIREDTV_DVB_S) fi->caps |= FE_CAN_FEC_AUTO;
before the break. But only if there really is a necessity for having the flag off for FireDTV-S2 boxes in DVB-S usage.
Signature · 3 lines
Stefan Richter -=====-==--= --=- ==--- http://arcgraph.de/sr/
PATCH 1/1 firedtv: dvb_frontend_info for FireDTV S2, fix "frequency limits undefined" error
From: Beat Michel Liechti <[email protected]>
I found that the function fdtv_frontend_init in the file firedtv-fe.c was missing a case for FIREDTV_DVB_S2 which resulted in "frequency limits undefined" errors in syslog.
Change by Stefan R: combine it with case case FIREDTV_DVB_S as originally suggested by Beat Michel. This enables FE_CAN_FEC_AUTO also for FireDTV-S2 devices which is possible as long as only DVB-S channels are used. FE_CAN_FEC_AUTO would be wrong for DVB-S2 channels, but those cannot be used yet since the driver is not yet converted to S2API.
---
If you don't mind, I commit this for now (want to send a mainline pull request later today) and we work out any remaining loose DVB-S2 ends from there.
drivers/media/dvb/firewire/firedtv-fe.c | 1 + 1 file changed, 1 insertion(+)
drivers/media/dvb/firewire/firedtv-fe.c +1 -0
@@ -185,6 +185,7 @@ void fdtv_frontend_init(struct firedtv *switch (fdtv->type) {case FIREDTV_DVB_S : +case FIREDTV_DVB_S2 : fi->type =FE_QPSK ; fi->frequency_min =950000 ;
Signature · 3 lines
Stefan Richter -=====-==--= --=- ==--- http://arcgraph.de/sr/