Skip to contentSkip to conversation

package/harfbuzz: needs gcc >= 4.8

PATCH New Bernd Kuhls 2 participants 27 messages Aug 3, 2019 – Aug 14, 2019

lore
Share & tools
lore
#0 lore raw

cover package/harfbuzz: needs gcc >= 4.8

Hi,

bumping harfbuzz to 2.5.2
https://git.buildroot.net/buildroot/commit/package/harfbuzz?id=c04e5cb16e3de688dfee585f47f22db4232acb3e

added a dependency on gcc >= 4.8:

https://github.com/harfbuzz/harfbuzz/blob/master/NEWS#L34
https://github.com/harfbuzz/harfbuzz/blob/master/NEWS#L14

This series adds this dependency to harfbuzz, host-harfbuzz and (hopefully) to all reverse dependencies.

Regards, Bernd

Bernd Kuhls (23):
package/cwiid: wmgui needs gcc >= 4.8 package/xscreensaver: needs gcc >= 4.8
package/rrdtool: rrd_graph support needs gcc >= 4.8 package/qt5/qt5base: harfbuzz support needs gcc >= 4.8 package/pinentry: pinentry-gtk2 needs gcc >= 4.8 package/pcmanfm: needs gcc >= 4.8
package/libfm: needs gcc >= 4.8
package/opencv: gtk support needs gcc >= 4.8 package/openbox: needs gcc >= 4.8 package/gstreamer/gst-plugins-bad: rsvg plugin needs gcc >= 4.8 package/gstreamer/gst-plugins-base: pango plugin needs gcc >= 4.8 package/gstreamer1/gst1-plugins-bad: rsvg plugin needs gcc >= 4.8 package/gstreamer1/gst1-plugins-base: pango plugin needs gcc >= 4.8 package/efl: SVG loader needs gcc >= 4.8 package/enlightenment: needs gcc >= 4.8 package/imagemagick: host svg support needs host gcc >= 4.8 package/vte: needs host gcc >= 4.8
package/librsvg: needs gcc >= 4.8
package/gtkmm3: needs host gcc >= 4.8
package/pango: needs gcc >= 4.8
package/libgtk2: needs gcc >= 4.8
package/libgtk3: needs gcc & host gcc >= 4.8 package/harfbuzz: needs gcc >= 4.8

 package/cwiid/Config.in                        | 3 ++-
 package/efl/Config.in                          | 1 +
 package/enlightenment/Config.in                | 4 +++-
 package/gstreamer/gst-plugins-bad/Config.in    | 6 ++++--
 package/gstreamer/gst-plugins-base/Config.in   | 6 ++++--
 package/gstreamer1/gst1-plugins-bad/Config.in  | 6 ++++--
 package/gstreamer1/gst1-plugins-base/Config.in | 6 ++++--
 package/gtkmm3/Config.in                       | 4 +++-
 package/harfbuzz/Config.in                     | 6 ++++--
 package/imagemagick/Config.in.host             | 4 ++++
 package/libfm/Config.in                        | 4 +++-
 package/libgtk2/Config.in                      | 4 +++-
 package/libgtk3/Config.in                      | 7 ++++++-
 package/librsvg/Config.in                      | 7 +++++--
 package/openbox/Config.in                      | 4 +++-
 package/opencv/Config.in                       | 1 +
 package/pango/Config.in                        | 4 +++-
 package/pcmanfm/Config.in                      | 4 +++-
 package/pinentry/Config.in                     | 4 +++-
 package/qt5/qt5base/Config.in                  | 4 +++-
 package/rrdtool/Config.in                      | 7 +++++--
 package/vte/Config.in                          | 4 +++-
 package/xscreensaver/Config.in                 | 4 +++-
 23 files changed, 77 insertions(+), 27 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/23 package/cwiid: wmgui needs gcc >= 4.8

Due to the harfbuzz bump to version 2.5.2 wmgui needs gcc >= 4.8.

Fixed typo in BR2_TOOLCHAIN_HAS_SYNC_4 comment.

---
 package/cwiid/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/cwiid/Config.in +2 -1
index 50c05ebd91..7ee8117355 100644
@@ -14,7 +14,8 @@ config BR2_PACKAGE_CWIID
 if BR2_PACKAGE_CWIID
 config BR2_PACKAGE_CWIID_WMGUI
 	bool "wmgui"
-	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libgtk3 -> pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libgtk2 -> pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # libgtk2 -> pango -> harfbuzz
 	depends on BR2_PACKAGE_XORG7 # libgtk2
 	depends on BR2_USE_WCHAR # libgtk2 -> libglib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libgtk2 -> libglib2
Signature · 1 line
2.20.1
#2 lore raw

PATCH 2/23 package/xscreensaver: needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 we need gcc >= 4.8.

---
 package/xscreensaver/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/xscreensaver/Config.in +3 -1
index efb8d1a6bc..c1d6a03f5d 100644
@@ -6,6 +6,7 @@ config BR2_PACKAGE_XSCREENSAVER
 	depends on BR2_USE_WCHAR # libgtk2 -> glib2
 	depends on BR2_USE_MMU # libgtk2 -> glib2
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libgtk2 -> pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # libgtk2 -> pango -> harfbuzz
 	select BR2_PACKAGE_LIBGTK2
 	select BR2_PACKAGE_LIBGLADE
 	select BR2_PACKAGE_JPEG
@@ -22,9 +23,10 @@ config BR2_PACKAGE_XSCREENSAVER
 
 	  http://www.jwz.org/xscreensaver/
 
-comment "xscreensaver needs a toolchain w/ wchar, C++, threads"
+comment "xscreensaver needs a toolchain w/ wchar, C++, threads, gcc >= 4.8"
 	depends on BR2_PACKAGE_XORG7
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
 		!BR2_USE_WCHAR
Signature · 1 line
2.20.1
#3 lore raw

PATCH 3/23 package/rrdtool: rrd_graph support needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 gcc >= 4.8 is needed for rrd_graph support.

Added BR2_TOOLCHAIN_HAS_SYNC_4 dependency to comment.

---
 package/rrdtool/Config.in | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
package/rrdtool/Config.in +5 -2
index 631ed32847..5451353140 100644
@@ -16,6 +16,7 @@ config BR2_PACKAGE_RRDTOOL_RRDGRAPH
 	bool "rrd_graph"
 	default y
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # pango -> harfbuzz
 	depends on BR2_INSTALL_LIBSTDCPP # freetype support from pango
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_PDF
@@ -27,8 +28,10 @@ config BR2_PACKAGE_RRDTOOL_RRDGRAPH
 	  This enables the graphing capabilities ('rrdgraph').
 	  Without this it will only act as a database backend.
 
-comment "rrd_graph support needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "rrd_graph support needs a toolchain w/ C++, gcc >= 4.8"
+	depends on !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 
 endif
 
Signature · 1 line
2.20.1
#4 lore raw

PATCH 4/23 package/qt5/qt5base: harfbuzz support needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 we need gcc >= 4.8.

---
 package/qt5/qt5base/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/qt5/qt5base/Config.in +3 -1
index 696e689758..c2f1736d95 100644
@@ -236,7 +236,9 @@ config BR2_PACKAGE_QT5BASE_FONTCONFIG
 
 config BR2_PACKAGE_QT5BASE_HARFBUZZ
 	bool "harfbuzz support"
-	select BR2_PACKAGE_HARFBUZZ if BR2_TOOLCHAIN_HAS_SYNC_4
+	select BR2_PACKAGE_HARFBUZZ if \
+		BR2_TOOLCHAIN_HAS_SYNC_4 && \
+		BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 	help
 	  This option enables HarfBuzz support (either system harfbuzz
 	  if the toolchain supports __sync for 4 bytes, or the qt
Signature · 1 line
2.20.1
#5 lore raw

PATCH 5/23 package/pinentry: pinentry-gtk2 needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 pinentry-gtk2 needs gcc >= 4.8.

---
 package/pinentry/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/pinentry/Config.in +3 -1
index 22bc2bb43d..518e3ad37f 100644
@@ -30,15 +30,17 @@ config BR2_PACKAGE_PINENTRY_GTK2
 	depends on BR2_USE_MMU
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libgtk2 -> pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # libgtk2 -> pango -> harfbuzz
 	select BR2_PACKAGE_LIBGTK2
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	help
 	  The pinentry-gtk2 tool
 
-comment "pinentry-gtk2 needs X and a toolchain w/ wchar, threads, C++"
+comment "pinentry-gtk2 needs X and a toolchain w/ wchar, threads, C++, gcc >= 4.8"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_PACKAGE_XORG7 || !BR2_USE_WCHAR || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
 		!BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_PINENTRY_QT5
Signature · 1 line
2.20.1
#6 lore raw

PATCH 6/23 package/pcmanfm: needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 we need gcc >= 4.8.

---
 package/pcmanfm/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/pcmanfm/Config.in +3 -1
index 69ddf00232..f281599637 100644
@@ -6,6 +6,7 @@ config BR2_PACKAGE_PCMANFM
 	depends on BR2_USE_MMU # libglib2
 	depends on BR2_INSTALL_LIBSTDCPP # libgtk2
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libgtk2 -> pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # libgtk2 -> pango -> harfbuzz
 	select BR2_PACKAGE_LIBFM
 	select BR2_PACKAGE_MENU_CACHE
 	select BR2_PACKAGE_LIBGLIB2
@@ -17,9 +18,10 @@ config BR2_PACKAGE_PCMANFM
 
 	  http://wiki.lxde.org/en/PCManFM
 
-comment "pcmanfm needs a toolchain w/ wchar, threads, C++"
+comment "pcmanfm needs a toolchain w/ wchar, threads, C++, gcc >= 4.8"
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_XORG7
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
 		!BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.20.1
#7 lore raw

PATCH 7/23 package/libfm: needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 we need gcc >= 4.8.

---
 package/libfm/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/libfm/Config.in +3 -1
index 81f2e10043..16676fbf25 100644
@@ -6,6 +6,7 @@ config BR2_PACKAGE_LIBFM
 	depends on BR2_USE_MMU # libglib2
 	depends on BR2_INSTALL_LIBSTDCPP # libgtk2
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libgtk2 -> pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # libgtk2 -> pango -> harfbuzz
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_LIBGTK2 if !BR2_PACKAGE_LIBGTK3_X11
@@ -21,8 +22,9 @@ config BR2_PACKAGE_LIBFM
 
 	  http://wiki.lxde.org/en/Libfm
 
-comment "libfm needs X.org and a toolchain w/ wchar, threads, C++"
+comment "libfm needs X.org and a toolchain w/ wchar, threads, C++, gcc >= 4.8"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
 		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_XORG7
Signature · 1 line
2.20.1
#8 lore raw

PATCH 8/23 package/opencv: gtk support needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 gtk support needs gcc >= 4.8.

---
 package/opencv/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/opencv/Config.in +1 -0
index 54094b29ca..c74dfd9572 100644
@@ -241,6 +241,7 @@ config BR2_PACKAGE_OPENCV_WITH_GTK
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_MMU # libgtk2 -> glib2
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libgtk2 -> pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # libgtk2 -> pango -> harfbuzz
 	depends on BR2_PACKAGE_OPENCV_LIB_HIGHGUI
 	select BR2_PACKAGE_LIBGTK2
 
Signature · 1 line
2.20.1
#9 lore raw

PATCH 9/23 package/openbox: needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 we need gcc >= 4.8.

---
 package/openbox/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/openbox/Config.in +3 -1
index 3ddd376803..fe6e886865 100644
@@ -5,6 +5,7 @@ config BR2_PACKAGE_OPENBOX
 	depends on BR2_USE_MMU # glib2
 	depends on BR2_USE_WCHAR # glib2
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # pango -> harfbuzz
 	depends on BR2_INSTALL_LIBSTDCPP # pango -> freetype
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_LIBXML2
@@ -19,9 +20,10 @@ config BR2_PACKAGE_OPENBOX
 
 	  http://openbox.org
 
-comment "openbox needs a toolchain w/ C++, threads, wchar"
+comment "openbox needs a toolchain w/ C++, threads, wchar, gcc >= 4.8"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
 		!BR2_INSTALL_LIBSTDCPP
 	depends on BR2_PACKAGE_XORG7
Signature · 1 line
2.20.1
#10 lore raw

PATCH 10/23 package/gstreamer/gst-plugins-bad: rsvg plugin needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 the rsvg plugin needs gcc >= 4.8.

---
 package/gstreamer/gst-plugins-bad/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/gstreamer/gst-plugins-bad/Config.in +4 -2
index 982edc2e4c..c96ceb69c4 100644
@@ -295,10 +295,12 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_RSVG
 	bool "rsvg"
 	depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # librsvg -> pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # librsvg -> pango -> harfbuzz
 	select BR2_PACKAGE_LIBRSVG
 
-comment "rsvg plugin needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "rsvg plugin needs a toolchain w/ C++, gcc >= 4.8"
+	depends on !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 
 config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_SDL
Signature · 1 line
2.20.1
#11 lore raw

PATCH 11/23 package/gstreamer/gst-plugins-base: pango plugin needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 the pango plugin needs gcc >= 4.8.

---
 package/gstreamer/gst-plugins-base/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/gstreamer/gst-plugins-base/Config.in +4 -2
index e9c8239f79..d784bcdd39 100644
@@ -83,10 +83,12 @@ config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_PANGO
 	bool "pango font renderer"
 	depends on BR2_INSTALL_LIBSTDCPP # pango -> freetype
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # pango -> harfbuzz
 	select BR2_PACKAGE_PANGO
 
-comment "pango plugin needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "pango plugin needs a toolchain w/ C++, gcc => 4.8"
+	depends on !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 
 config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_SUBPARSE
Signature · 1 line
2.20.1
#12 lore raw

PATCH 12/23 package/gstreamer1/gst1-plugins-bad: rsvg plugin needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 the rsvg plugin needs gcc >= 4.8.

---
 package/gstreamer1/gst1-plugins-bad/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/gstreamer1/gst1-plugins-bad/Config.in +4 -2
index f00f3edb7c..e79f266ad0 100644
@@ -520,12 +520,14 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RSVG
 	bool "rsvg"
 	depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # librsvg -> pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # librsvg -> pango -> harfbuzz
 	select BR2_PACKAGE_LIBRSVG
 	help
 	  RSVG plugin library
 
-comment "rsvg plugin needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "rsvg plugin needs a toolchain w/ C++, gcc >= 4.8"
+	depends on !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SBC
Signature · 1 line
2.20.1
#13 lore raw

PATCH 13/23 package/gstreamer1/gst1-plugins-base: pango plugin needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 the pango plugin needs gcc >= 4.8.

---
 package/gstreamer1/gst1-plugins-base/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/gstreamer1/gst1-plugins-base/Config.in +4 -2
index 29f8001f3a..f60d540337 100644
@@ -282,12 +282,14 @@ config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PANGO
 	bool "pango font renderer"
 	depends on BR2_INSTALL_LIBSTDCPP # pango -> freetype
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # pango -> harfbuzz
 	select BR2_PACKAGE_PANGO
 	help
 	  Pango-based text rendering and overlay
 
-comment "pango plugin needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "pango plugin needs a toolchain w/ C++, gcc >= 4.8"
+	depends on !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 
 config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_THEORA
Signature · 1 line
2.20.1
#14 lore raw

PATCH 14/23 package/efl: SVG loader needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 the SVG loader needs gcc >= 4.8.

---
 package/efl/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/efl/Config.in +1 -0
index 05be5aae56..4d98c187c1 100644
@@ -295,6 +295,7 @@ config BR2_PACKAGE_EFL_LIBRAW
 config BR2_PACKAGE_EFL_SVG
 	bool "SVG loader"
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # librsvg -> pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # librsvg -> pango -> harfbuzz
 	select BR2_PACKAGE_LIBRSVG
 	select BR2_PACKAGE_CAIRO
 	help
Signature · 1 line
2.20.1
#15 lore raw

PATCH 15/23 package/enlightenment: needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 we need gcc >= 4.8.

---
 package/enlightenment/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/enlightenment/Config.in +3 -1
index d1dee25f86..2cd6512e1e 100644
@@ -13,6 +13,7 @@ config BR2_PACKAGE_ENLIGHTENMENT
 	depends on BR2_PACKAGE_XORG7
 	# libevas-generic-loaders-svg -> librsvg -> pango -> harfbuzz
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 	select BR2_PACKAGE_EFL_X_XLIB
 	select BR2_PACKAGE_EFL_EEZE
 	select BR2_PACKAGE_EFL_JPEG # needed at runtime by enlightenment_start
@@ -28,8 +29,9 @@ config BR2_PACKAGE_ENLIGHTENMENT
 
 	  http://www.enlightenment.org/
 
-comment "enlightenment needs udev /dev management and a toolchain w/ wchar, C++, threads"
+comment "enlightenment needs udev /dev management and a toolchain w/ wchar, C++, threads, gcc >= 4.8"
 	depends on BR2_PACKAGE_EFL && BR2_PACKAGE_XORG7 && BR2_USE_MMU
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
 		!BR2_PACKAGE_HAS_UDEV
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
Signature · 1 line
2.20.1
#16 lore raw

PATCH 16/23 package/imagemagick: host svg support needs host gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 host SVG support needs host gcc >= 4.8.

---
 package/imagemagick/Config.in.host | 4 ++++
 1 file changed, 4 insertions(+)
package/imagemagick/Config.in.host +4 -0
index bbe23baa6f..5a87a130ee 100644
@@ -16,6 +16,7 @@ if BR2_PACKAGE_HOST_IMAGEMAGICK
 
 config BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
 	bool "SVG support"
+	depends on BR2_HOST_GCC_AT_LEAST_4_8 # host-librsvg -> host-pango -> host-harfbuzz
 	help
 	  Say 'y' here is you need ImageMagick tools (like convert)
 	  to support SVG.
@@ -23,4 +24,7 @@ config BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
 	  This is not enabled by default, as it brings quite a few
 	  extra dependencies, and thus extra build time.
 
+comment "SVG support needs host gcc >= 4.8"
+	depends on !BR2_HOST_GCC_AT_LEAST_4_8
+
 endif
Signature · 1 line
2.20.1
#17 lore raw

PATCH 17/23 package/vte: needs host gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 we need host gcc >= 4.8.

---
 package/vte/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/vte/Config.in +3 -1
index fa29de8c71..5710ee9e0f 100644
@@ -5,6 +5,7 @@ config BR2_PACKAGE_VTE
 	depends on BR2_USE_MMU
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
+	depends on BR2_HOST_GCC_AT_LEAST_4_8 # libgtk3 -> pango -> harfbuzz
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND || \
 		BR2_PACKAGE_HAS_LIBGL
@@ -21,11 +22,12 @@ config BR2_PACKAGE_VTE
 
 	  http://github.com/GNOME/vte
 
-comment "vte needs a toolchain w/ wchar, threads, C++, gcc >= 4.8"
+comment "vte needs a toolchain w/ wchar, threads, C++, gcc >= 4.8, host gcc >= 4.8"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_HOST_GCC_AT_LEAST_4_8 || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 
 comment "vte needs an OpenGL or an OpenGL-EGL/wayland backend"
Signature · 1 line
2.20.1
#18 lore raw

PATCH 18/23 package/librsvg: needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 we need gcc >= 4.8.

---
 package/librsvg/Config.in | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
package/librsvg/Config.in +5 -2
index ffb0287dbd..735bf61259 100644
@@ -5,6 +5,7 @@ config BR2_PACKAGE_LIBRSVG
 	depends on BR2_USE_MMU # glib2
 	depends on BR2_INSTALL_LIBSTDCPP # pango
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # pango -> harfbuzz
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_PNG
 	select BR2_PACKAGE_GDK_PIXBUF
@@ -18,7 +19,9 @@ config BR2_PACKAGE_LIBRSVG
 
 	  https://wiki.gnome.org/Projects/LibRsvg
 
-comment "librsvg needs a toolchain w/ wchar, threads, C++"
+comment "librsvg needs a toolchain w/ wchar, threads, C++, gcc >= 4.8"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
+		!BR2_INSTALL_LIBSTDCPP
Signature · 1 line
2.20.1
#19 lore raw

PATCH 19/23 package/gtkmm3: needs host gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 we need host gcc >= 4.8.

---
 package/gtkmm3/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/gtkmm3/Config.in +3 -1
index 8762c7208d..fb64a0e697 100644
@@ -1,8 +1,9 @@
-comment "gtkmm3 needs libgtk3 and a toolchain w/ C++, wchar, threads, gcc >= 4.9"
+comment "gtkmm3 needs libgtk3 and a toolchain w/ C++, wchar, threads, gcc >= 4.9, host gcc >= 4.8"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || !BR2_USE_WCHAR \
 		|| !BR2_INSTALL_LIBSTDCPP || !BR2_PACKAGE_LIBGTK3 \
+		|| !BR2_HOST_GCC_AT_LEAST_4_8 \
 		|| !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_GTKMM3
@@ -15,6 +16,7 @@ config BR2_PACKAGE_GTKMM3
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pangomm, libgtk3 -> pango -> harfbuzz
 	depends on BR2_INSTALL_LIBSTDCPP # glibmm, libpangomm -> glibmm/pango
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11
+	depends on BR2_HOST_GCC_AT_LEAST_4_8 # libgtk3 -> pango -> harfbuzz
 	depends on BR2_TOOLCHAIN_HAS_THREADS # *mm/libgtk3 -> libglib2
 	depends on BR2_USE_MMU # *mm/libgtk3 -> libglib2
 	depends on BR2_USE_WCHAR # *mm/libgtk3 -> libglib2
Signature · 1 line
2.20.1
#20 lore raw

PATCH 20/23 package/pango: needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 we need gcc >= 4.8.

---
 package/pango/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/pango/Config.in +3 -1
index e8a5318675..cdf8b54171 100644
@@ -5,6 +5,7 @@ config BR2_PACKAGE_PANGO
 	depends on BR2_USE_MMU # glib2
 	depends on BR2_INSTALL_LIBSTDCPP # freetype support
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # harfbuzz
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_EXPAT
 	select BR2_PACKAGE_CAIRO
@@ -22,8 +23,9 @@ config BR2_PACKAGE_PANGO
 
 	  http://www.pango.org/
 
-comment "pango needs a toolchain w/ wchar, threads, C++"
+comment "pango needs a toolchain w/ wchar, threads, C++, gcc >= 4.8"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
 		!BR2_INSTALL_LIBSTDCPP
Signature · 1 line
2.20.1
#21 lore raw

PATCH 21/23 package/libgtk2: needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 we need gcc >= 4.8.

---
 package/libgtk2/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/libgtk2/Config.in +3 -1
index aa297d71ef..7c5762a585 100644
@@ -6,6 +6,7 @@ config BR2_PACKAGE_LIBGTK2
 	depends on BR2_USE_MMU # glib2
 	depends on BR2_INSTALL_LIBSTDCPP # pango
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # pango -> harfbuzz
 	select BR2_PACKAGE_ATK
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_PS
@@ -33,9 +34,10 @@ config BR2_PACKAGE_LIBGTK2_DEMO
 
 endif
 
-comment "libgtk2 needs a toolchain w/ wchar, threads, C++"
+comment "libgtk2 needs a toolchain w/ wchar, threads, C++, gcc >= 4.8"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on BR2_PACKAGE_XORG7
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
 		!BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.20.1
#22 lore raw

PATCH 22/23 package/libgtk3: needs gcc & host gcc >= 4.8

In reply to Bernd Kuhls

Due to the harfbuzz bump to version 2.5.2 we need gcc >= 4.8.

---
 package/libgtk3/Config.in | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
package/libgtk3/Config.in +6 -1
index 12e64707bd..72737d6e2f 100644
@@ -1,7 +1,9 @@
-comment "libgtk3 needs a toolchain w/ wchar, threads, C++"
+comment "libgtk3 needs a toolchain w/ wchar, threads, C++, gcc >= 4.8, host gcc >= 4.8"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
+		!BR2_HOST_GCC_AT_LEAST_4_8 || \
 		!BR2_TOOLCHAIN_HAS_THREADS
 
 comment "libgtk3 needs an OpenGL or an OpenGL-EGL/wayland backend"
@@ -17,6 +19,9 @@ config BR2_PACKAGE_LIBGTK3
 	depends on BR2_USE_MMU # glib2
 	depends on BR2_INSTALL_LIBSTDCPP # pango
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango -> harfbuzz
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # pango -> harfbuzz
+	# host-libgtk3 -> host-librsvg -> host-pango -> host-harfbuzz
+	depends on BR2_HOST_GCC_AT_LEAST_4_8
 	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND || \
 		BR2_PACKAGE_HAS_LIBGL
 	select BR2_PACKAGE_ATK
Signature · 1 line
2.20.1
#23 lore raw

PATCH 23/23 package/harfbuzz: needs gcc >= 4.8

In reply to Bernd Kuhls

Due to the version bump to 2.5.2 we need gcc >= 4.8.

Fixes:
http://autobuild.buildroot.net/results/924/9247b9773099d7995ad8fa1665dd768bb550f63c/

---
 package/harfbuzz/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/harfbuzz/Config.in +4 -2
index a6db9840cc..e8f407bb8f 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_HARFBUZZ
 	bool "harfbuzz"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 	help
 	  HarfBuzz is an OpenType text shaping engine
 
@@ -10,6 +11,7 @@ config BR2_PACKAGE_HARFBUZZ
 	  Harfbuzz can make optional use of cairo, freetype,
 	  glib2 and icu packages if they are selected.
 
-comment "harfbuzz needs a toolchain w/ C++"
+comment "harfbuzz needs a toolchain w/ C++, gcc => 4.8"
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
-	depends on !BR2_INSTALL_LIBSTDCPP
+	depends on !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
Signature · 1 line
2.20.1
#24 lore raw

cover package/harfbuzz: needs gcc >= 4.8

In reply to Bernd Kuhls

Hello Bernd,

Quoted 10 lines · On Sat, 3 Aug 2019 21:14:38 +0200 Bernd Kuhls <[email protected]> wrote:

bumping harfbuzz to 2.5.2
https://git.buildroot.net/buildroot/commit/package/harfbuzz?id=c04e5cb16e3de688dfee585f47f22db4232acb3e

added a dependency on gcc >= 4.8:

https://github.com/harfbuzz/harfbuzz/blob/master/NEWS#L34
https://github.com/harfbuzz/harfbuzz/blob/master/NEWS#L14

This series adds this dependency to harfbuzz, host-harfbuzz and (hopefully) to all reverse dependencies.

Thanks a lot, I've applied the series to master.

However, it is worth mentioning that we have another, unrelated, issue with the harfbuzz bump: it fails to build on m68k (with a gcc 7.x toolchain):

http://autobuild.buildroot.net/?reason=harfbuzz%

THe problem can easily be reproduced, but I'm not sure why it is specific to m68k. Any clue ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#25 lore raw

cover package/harfbuzz: needs gcc >= 4.8

Am Sun, 11 Aug 2019 23:18:45 +0200 schrieb Thomas Petazzoni:

Quoted 8 lines

However, it is worth mentioning that we have another, unrelated, issue with the harfbuzz bump: it fails to build on m68k (with a gcc 7.x toolchain):

http://autobuild.buildroot.net/?reason=harfbuzz%

THe problem can easily be reproduced, but I'm not sure why it is specific to m68k. Any clue ?

Hi Thomas,

no idea, opened bug report upstream:
https://github.com/harfbuzz/harfbuzz/issues/1901

Regards, Bernd

#26 lore raw

cover package/harfbuzz: needs gcc >= 4.8

In reply to Bernd Kuhls

Hello,

+Eric Le Bihan in Cc. Eric there is some question below related to work you've done.

Quoted 10 lines · On Sat, 3 Aug 2019 21:14:38 +0200 Bernd Kuhls <[email protected]> wrote:

bumping harfbuzz to 2.5.2
https://git.buildroot.net/buildroot/commit/package/harfbuzz?id=c04e5cb16e3de688dfee585f47f22db4232acb3e

added a dependency on gcc >= 4.8:

https://github.com/harfbuzz/harfbuzz/blob/master/NEWS#L34
https://github.com/harfbuzz/harfbuzz/blob/master/NEWS#L14

This series adds this dependency to harfbuzz, host-harfbuzz and (hopefully) to all reverse dependencies.

With this series, we are still getting some failures with host-harfbuzz. I noted one:

http://autobuild.buildroot.net/results/a8d/a8d6a4e96b2949247e4cc43055520d65ba705972/build-end.log

The problem is that adwaita-icon-theme can be enable either when libgtk2 *or* libgtk3 are enabled, but depends on host-libgtk3, which ultimately will need host-harfbuzz. And host-harfbuzz needs host gcc >= 4.8.

So the most immediate solution is obviously to add a host gcc >= 4.8 dependency to adwaita-icon-theme.

However, the fact that adwaita-icon-theme can be used with libgtk2, but needs host-libgtk3 got my attention, so I looked at the history of this package.

Initially, it was added by Eric in commit edc92b68afb66ea8ec562afc8bbe3d5ae10b74c8, with no special dependency. Not longer after that, in commit 704c540203ddd217d7bcf6d371fc87a079c0be9b, Eric made the package depend on BR2_PACKAGE_LIBGTK3 and added host-libgtk3 to the dependencies.

About half a year later, in commit 32ac8fb04875f94b7f0c6a48e3dd9f3f6c2cfa93, Gustavo Zacarias then changed the Config.in dependency to libgtk2 || libgtk3, but kept the host-libgtk3 dependency in the makefile. It is not clear to me if this is correct.

Eric, do you know why the dependency on host-libgtk3 is needed ? I can imagine because of the need for gtk-update-icon-cache ? But what happens in the libgtk2 situation ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com