net: sched: potential NULL dereference in tcf_block_find()
Subsystems (4)
PATCH 1/1 net: sched: potential NULL dereference in tcf_block_find()
The error code isn't set on this path so it would result in returning ERR_PTR(0) and a NULL dereference in the caller.
Fixes 18d3eefb17cf ("net: sched: refactor tcf_block_find() into standalone functions")
Signed-off-by Dan Carpenter <[email protected]>
--- net/sched/cls_api.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
net/sched/cls_api.c +3 -1
@@ -1310,8 +1310,10 @@ static struct tcf_block *tcf_block_find(struct net *net, struct Qdisc **q, goto errout_qdisc; block =__tcf_block_find (net, *q, *cl, ifindex, block_index, extack); -if (IS_ERR (block)) +if (IS_ERR (block)) { + err =PTR_ERR (block); goto errout_qdisc; + }return block;
Signature · 1 line
2.17.1
Quoted 5 lines · Dan Carpenter
The error code isn't set on this path so it would result in returning
ERR_PTR(0)and a NULL dereference in the caller.Fixes 18d3eefb17cf ("net: sched: refactor tcf_block_find() into standalone functions")Signed-off-by Dan Carpenter <[email protected]>
Hi Dan,
Thank you for finding and fixing this!
Regards,
Vlad
From: Dan Carpenter <[email protected]>
Date: Mon, 18 Feb 2019 12:26:32 +0300
Quoted 5 lines
The error code isn't set on this path so it would result in returning
ERR_PTR(0)and a NULL dereference in the caller.Fixes 18d3eefb17cf ("net: sched: refactor tcf_block_find() into standalone functions")Signed-off-by Dan Carpenter <[email protected]>
Applied, thanks.