Skip to contentSkip to conversation

PPPoE Oops with 2.4.22-rc

PATCH Junio C Hamano 3 participants 3 messages Aug 22, 2003 – Aug 25, 2003 2 messages not in the archive Network drivers

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Junio C Hamano

author
#2 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"MS" == Marcus Sundberg <[email protected]> writes:

MS> this patch fixes one crash in pppoe_connect():

drivers/net/pppoe.c renamed from drivers/net/pppoe.c~ +2 -1
@@ -606,7 +606,8 @@
 		/* Delete the old binding */
 		delete_item(po->pppoe_pa.sid,po->pppoe_pa.remote);
 
-		dev_put(po->pppoe_dev);
+		if (po->pppoe_dev)
+			dev_put(po->pppoe_dev);
 
 		memset(po, 0, sizeof(struct pppox_opt));
 		po->sk = sk;

Could you explain when/how pppoe_connect gets called with (pppoe_dev == NULL) but with an old binding?

#3 lore raw
Quoted 17 lines · Junio C Hamano
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"MS" == Marcus Sundberg <[email protected]> writes:

MS> this patch fixes one crash in pppoe_connect():

drivers/net/pppoe.c renamed from drivers/net/pppoe.c~ +2 -1
@@ -606,7 +606,8 @@
 		/* Delete the old binding */
 		delete_item(po->pppoe_pa.sid,po->pppoe_pa.remote);
 
-		dev_put(po->pppoe_dev);
+		if (po->pppoe_dev)
+			dev_put(po->pppoe_dev);
 
 		memset(po, 0, sizeof(struct pppox_opt));
 		po->sk = sk;
Quoted 2 lines

Could you explain when/how pppoe_connect gets called with (pppoe_dev == NULL) but with an old binding?

I triggered it by doing 'ifconfig down' on the underlying ethernet device. It's possible there are other ways to trigger it also. When I made the fix I just looked at where the oops occured.

//Marcus

Signature · 3 lines
---------------------------------------+--------------------------
  Marcus Sundberg <[email protected]>  | Firewalls with SIP & NAT
 Firewall Developer, Ingate Systems AB |  http://www.ingate.com/
#4 lore raw
Quoted 2 lines · Marcus Sundberg

I triggered it by doing 'ifconfig down' on the underlying ethernet device. It's possible there are other ways to trigger it also.

Thank you. This has been a bug for a little while. I reported it with 2.4.20 a few months ago.

Signature · 1 line
greg