maintenance: fix launchctl calendar intervals
cover maintenance: fix launchctl calendar intervals
Hello!
While working to add git maintenance support to home-manager[1] on macOS, I noticed that the calendar intervals are set up incorrectly for the launchctl scheduler. With the current settings daily jobs run on the first six days of the month, and weekly jobs run daily. I've confirmed this behaviour by manually shifting my system time around and checking the system logs. This seems mostly harmless, and I think git maintenance is somewhat niche, so I don't think we need to worry about proactively correcting existing launchd configurations somehow.
[1] https://github.com/nix-community/home-manager
Josh Heinrichs (1):
maintenance: fix launchctl calendar intervals
builtin/gc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
base-commit: 683c54c999c301c2cd6f715c411407c413b1d84e
Signature · 1 line
2.47.2
PATCH 1/1 maintenance: fix launchctl calendar intervals
When using the launchctl scheduler, the weekly job runs daily, and the daily job runs on the first six days of each month. This appears to be due to specifying "Day" in the calendar intervals, which according to launchd.plist(5) is for specifying days of the month rather than days of the week. The behaviour of running a job on the 0th day is undocumented, but in my testing appears to be the same as not specifying "Day" in the calendar interval, in which case the job will run daily.
Use "Weekday" in the calendar intervals, which is the correct way to schedule jobs to run on specific days of the week.
--- builtin/gc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
builtin/gc.c +2 -2
@@ -2075,7 +2075,7 @@ static int launchctl_schedule_plist(const char *exec_path, enum schedule_prioritcase SCHEDULE_DAILY : repeat ="<dict>\n" -"<key>Day</key><integer>%d</integer>\n" +"<key>Weekday</key><integer>%d</integer>\n" "<key>Hour</key><integer>0</integer>\n" "<key>Minute</key><integer>%d</integer>\n" "</dict>\n" ;
@@ -2086,7 +2086,7 @@ static int launchctl_schedule_plist(const char *exec_path, enum schedule_prioritcase SCHEDULE_WEEKLY : strbuf_addf(&plist, "<dict>\n" - "<key>Day</key><integer>0</integer>\n" + "<key>Weekday</key><integer>0</integer>\n" "<key>Hour</key><integer>0</integer>\n" "<key>Minute</key><integer>%d</integer>\n" "</dict>\n",
Signature · 1 line
2.47.2
Quoted 8 lines · Josh Heinrichs
When using the launchctl scheduler, the weekly job runs daily, and the daily job runs on the first six days of each month. This appears to be due to specifying "Day" in the calendar intervals, which according to
launchd.plist(5)is for specifying days of the month rather than days of the week. The behaviour of running a job on the 0th day is undocumented, but in my testing appears to be the same as not specifying "Day" in the calendar interval, in which case the job will run daily.
Quoted 5 lines
Use "Weekday" in the calendar intervals, which is the correct way to schedule jobs to run on specific days of the week.
Signed-off-by Josh Heinrichs <[email protected]>---
With a bit wider context, the patch looks like so. As I do not use macOS or launchctl myself, my guess may be way off but please bear with me.
Quoted 12 lines
builtin/gc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)builtin/gc.c +0
-0@@ -2072,24 +2072,24 @@ static int launchctl_schedule_plist(const char *exec_path, enum schedule_prioritfor (i =1 ; i <=23 ; i++)strbuf_addf (&plist, repeat, i, minute);break ;
builtin/gc.c static int launchctl_schedule_plist(const char *exec_path, enum schedule_priorit · line 2084
Quoted 10 lines
builtin/gc.c +1
-1case SCHEDULE_DAILY : repeat ="<dict>\n" -"<key>Day</key><integer>%d</integer>\n" +"<key>Weekday</key><integer>%d</integer>\n" "<key>Hour</key><integer>0</integer>\n" "<key>Minute</key><integer>%d</integer>\n" "</dict>\n" ;for (i =1 ; i <=6 ; i++)strbuf_addf (&plist, repeat, i, minute);break ;
So we used to say that "we want the task to run on days 1 thru 6 (6 days in total) of a month at certain minute of the day past midnight", which clearly not how people think of "daily" task.
Updated one specifies the task to run on day 1 (Monday) thru 6 (Saturday) of a week. The manual page seems to say that day 0 and day 7 of a week are both Sundays.
https://www.manpagez.com/man/5/launchd.plist/ look for StartCalendarInterval to read about Day and Weekday.
Curious that day 7/0 are ignored. Other schedulers are somewhat inconsistent but generally agree, so I won't worry about changing it in this patch. schtasks_schedule_task() excludes Sundays, and crontab_update_schedule() says that it wants to run daily scheduled tasks on day 1-6. systemd_timer_write_timer_file() however seems to say that it wants to run things on Tue..Sun (excluding Mondays), which may want to be corrected, I dunno.
builtin/gc.c static int launchctl_schedule_plist(const char *exec_path, enum schedule_priorit
Quoted 10 lines
builtin/gc.c +1
-1case SCHEDULE_WEEKLY :strbuf_addf (&plist,"<dict>\n" -"<key>Day</key><integer>0</integer>\n" +"<key>Weekday</key><integer>0</integer>\n" "<key>Hour</key><integer>0</integer>\n" "<key>Minute</key><integer>%d</integer>\n" "</dict>\n" , minute);break ;
This one used to say "run on 0th day of the month", but now it says "run on 0th day of the week", which is on Sundays. Makes sense.
Will queue. Thanks.
Quoted 10 lines · Junio C Hamano
Quoted 8 lines · Josh Heinrichs
When using the launchctl scheduler, the weekly job runs daily, and the daily job runs on the first six days of each month. This appears to be due to specifying "Day" in the calendar intervals, which according to
launchd.plist(5)is for specifying days of the month rather than days of the week. The behaviour of running a job on the 0th day is undocumented, but in my testing appears to be the same as not specifying "Day" in the calendar interval, in which case the job will run daily.
Quoted 2 lines
Quoted 2 lines
Use "Weekday" in the calendar intervals, which is the correct way to schedule jobs to run on specific days of the week.
Wow, good find! Thank you for submitting a fix for this issue.
Thanks,
-Stolee
Quoted 11 lines · Derrick Stolee
Quoted 10 lines · Junio C Hamano
Quoted 8 lines · Josh Heinrichs
When using the launchctl scheduler, the weekly job runs daily, and the daily job runs on the first six days of each month. This appears to be due to specifying "Day" in the calendar intervals, which according to
launchd.plist(5)is for specifying days of the month rather than days of the week. The behaviour of running a job on the 0th day is undocumented, but in my testing appears to be the same as not specifying "Day" in the calendar interval, in which case the job will run daily.
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Use "Weekday" in the calendar intervals, which is the correct way to schedule jobs to run on specific days of the week.
Wow, good find! Thank you for submitting a fix for this issue.
Yes, good find indeed. Tweaked in your Acked-by and will merge to 'next'.
Thanks, all.