commit: add a commit.signOff config variable
PATCH v2 1/1 commit: add a commit.signOff config variable
Add the commit.signOff configuration variable to use the -s or --signoff option of git commit by default.
Convenience for those who prefer to add Signed-off-by line by the committer instead of using format.signOff variable.
---
Previous version of the patch:
[v1]: https://public-inbox.org/git/[email protected]/
Changes in v2:
* Update commit message: Move commentary explains to commit message.
* Update test: Just test two combinations.
Documentation/config.txt | 4 ++++ Documentation/git-commit.txt | 2 ++ builtin/commit.c | 4 ++++ t/t7501-commit.sh | 10 ++++++++++ 4 files changed, 20 insertions(+)
Documentation/config.txt +4 -0
@@ -1303,6 +1303,10 @@ commit.gpgSign:: convenient to use an agent to avoid typing your GPG passphrase several times. +commit.signOff:: + A boolean value which lets you enable the `-s/--signoff` option of + `git commit` by default. See linkgit:git-commit[1]. + commit.status:: A boolean to enable/disable inclusion of status information in the commit message template when using an editor to prepare the commit
Documentation/git-commit.txt +2 -0
@@ -166,6 +166,8 @@ The `-m` option is mutually exclusive with `-c`, `-C`, and `-F`. the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see http://developercertificate.org/ for more information). + See the `commit.signOff` configuration variable in + linkgit:git-config[1]. -n:: --no-verify::
builtin/commit.c +4 -0
@@ -1548,6 +1548,10 @@ static int git_commit_config(const char *k, const char *v, void *cb) sign_commit =git_config_bool (k, v) ?"" :NULL ;return 0 ; } +if (!strcmp (k,"commit.signoff" )) { + signoff =git_config_bool (k, v); +return 0 ; + }if (!strcmp (k,"commit.verbose" )) {int is_bool; config_commit_verbose =git_config_bool_or_int (k, v, &is_bool);
t/t7501-commit.sh +10 -0
@@ -505,6 +505,16 @@ Myfooter: x" && test_cmp expected actual ' +test_expect_success 'commit.signoff=true & --signoff omitted' ' + git -c commit.signoff=true commit --allow-empty -m x && + git log -1 --format=%B | grep ^Signed-off-by: +' + +test_expect_success 'commit.signoff=true & --no-signoff' ' + git -c commit.signoff=true commit --allow-empty -m x --no-signoff && + ! git log -1 --format=%B | grep ^Signed-off-by: +' + test_expect_success 'multiple -m' ' >negative &&
Signature · 1 line
2.16.1.70.g5ccd54536
Quoted 2 lines · Chen Jingpiao
Add the commit.signOff configuration variable to use the -s or --signoff option of git commit by default.
This is a rather old topic. Here is one from 2006:
https://public-inbox.org/git/Pine.LNX.4.63.0611281426311.30004@wbgn013.biozentrum.uni-wuerzburg.de/
which was referred to in another discussion in late 2008:
https://public-inbox.org/git/[email protected]/ https://public-inbox.org/git/[email protected]/
I am not sure if the reasons why the last effort was retracted still apply to this round (the world certainly has changed in the past 10 years); it would be good to explain why this time it is different ;-).
Assuming that the new configuration variable is a desirable thing to add, the change to the code looks OK. Documentation updates may need more thought in the light of past discussions, though.
Thanks.
Quoted 19 lines · Junio C Hamano
Quoted 2 lines · Chen Jingpiao
Add the commit.signOff configuration variable to use the -s or --signoff option of git commit by default.
This is a rather old topic. Here is one from 2006:
https://public-inbox.org/git/Pine.LNX.4.63.0611281426311.30004@wbgn013.biozentrum.uni-wuerzburg.de/which was referred to in another discussion in late 2008:
https://public-inbox.org/git/[email protected]/ https://public-inbox.org/git/[email protected]/I am not sure if the reasons why the last effort was retracted still apply to this round (the world certainly has changed in the past 10 years); it would be good to explain why this time it is different ;-).
Quoted 5 lines
Assuming that the new configuration variable is a desirable thing to add, the change to the code looks OK. Documentation updates may need more thought in the light of past discussions, though.
Thanks.
I agree with Johannes Schindelin once said "a signoff _has_ to be a conscious act, or else it will lose its meaning."
I think I shouldn't add this configuration variable. Thank you.
--
Chen Jingpiao