instaweb: fix ip binding for the python http.server
PATCH 1/1 instaweb: fix ip binding for the python http.server
git instaweb -d python should bind the server to 0.0.0.0 git instaweb -d python -l should bind the server to 127.0.0.1
--- git-instaweb.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
git-instaweb.sh +2 -2
@@ -694,9 +694,9 @@ class GitWebRequestHandler(CGIHTTPRequestHandler): return result -bind = "127.0.0.1" +bind = "0.0.0.0" if "$local" == "true": - bind = "0.0.0.0" + bind = "127.0.0.1" # Set our http root directory # This is a work around for a missing directory argument in older Python versions
Signature · 1 line
2.47.1
Quoted 2 lines · Alecs King
git instaweb -d pythonshould bind the server to 0.0.0.0git instaweb -d python -lshould bind the server to 127.0.0.1
That is a correct statement of the fact. What makes this patch worthwhile is that the current code gets it the other way around since its inception at 2eb14bb2 (git-instaweb: add Python builtin http.server support, 2019-01-28).
Well spotted.
There seem to be some backends that simply ignore the "--local" option. Should they be somehow "fixed" (or at least making it a documented bug)? It is not within the scope of this patch, but since the script has our attention...
Thanks, will queue.
Quoted 22 lines
Signed-off-by Alecs King <[email protected]>--- git-instaweb.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)git-instaweb.sh +2
-2@@ -694,9 +694,9 @@ class GitWebRequestHandler(CGIHTTPRequestHandler): return result -bind = "127.0.0.1" +bind = "0.0.0.0" if "$local" == "true": - bind = "0.0.0.0" + bind = "127.0.0.1" # Set our http root directory # This is a work around for a missing directory argument in older Python versions
Quoted 2 lines · Alecs King
git instaweb -d pythonshould bind the server to 0.0.0.0git instaweb -d python -lshould bind the server to 127.0.0.1
Thanks for noticing that bug and sending a patch!
Quoted 1 line
GitWebRequestHandler(CGIHTTPRequestHandler):
NB: Looks like CGI support will be removed some time in the future and the Python backend for instaweb will stop working afterwards.
https://docs.python.org/3.13/library/http.server.html#http.server.CGIHTTPRequestHandler
When I get the time I should look into cleaning up the instaweb script.