t2019: skip test requiring '*' in a file name non Windows
PATCH 1/1 t2019: skip test requiring '*' in a file name non Windows
A test case introduced by ae454f61 (Add tests for wildcard "path vs ref" disambiguation) allocates a file named '*.c'. This does not work on Windows, because the OS forbids file names containing wildcard characters. The test case fails where the shell attempts to allocate the file. Skip the test on Windows.
---
This fixes a new failure in the test suite (t3404.8[67]) on Windows, but I got around to debug it only now.
t/t2019-checkout-ambiguous-ref.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
t/t2019-checkout-ambiguous-ref.sh +1 -1
@@ -69,7 +69,7 @@ test_expect_success 'wildcard ambiguation, paths win' ' ) ' -test_expect_success 'wildcard ambiguation, refs lose' ' +test_expect_success !MINGW 'wildcard ambiguation, refs lose' ' git init ambi2 && ( cd ambi2 &&
Signature · 21 lines
2.3.2.245.gb5bf9d3 -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "Git for Windows" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
Hi,
Quoted 6 lines · Johannes Sixt
t/t2019-checkout-ambiguous-ref.sh +0
-0
t/t2019-checkout-ambiguous-ref.sh test_expect_success 'wildcard ambiguation, paths win' ' · line 75
Quoted 8 lines
t/t2019-checkout-ambiguous-ref.sh +1
-1@@ -69,7 +69,7 @@ test_expect_success 'wildcard ambiguation, paths win' ' ) ' -test_expect_success 'wildcard ambiguation, refs lose' ' +test_expect_success !MINGW 'wildcard ambiguation, refs lose' ' git init ambi2 && ( cd ambi2 &&
FWIW I planned to submit a patch including this fix:
https://github.com/git-for-windows/git/commit/4694320330e1b4d9178e13e215ce60a1cc8e0b1c
(The idea of the fixup! was to make this change part of a larger change during the next merging rebase of Git for Windows.)
Ciao,
Johannes
Signature · 18 lines
-- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "Git for Windows" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
Quoted 21 lines · Johannes Schindelin
Hi,
Quoted 6 lines · Johannes Sixt
t/t2019-checkout-ambiguous-ref.sh +0
-0t/t2019-checkout-ambiguous-ref.sh test_expect_success 'wildcard ambiguation, paths win' ' · line 75
Quoted 8 lines
t/t2019-checkout-ambiguous-ref.sh +1
-1@@ -69,7 +69,7 @@ test_expect_success 'wildcard ambiguation, paths win' ' ) ' -test_expect_success 'wildcard ambiguation, refs lose' ' +test_expect_success !MINGW 'wildcard ambiguation, refs lose' ' git init ambi2 && ( cd ambi2 &&FWIW I planned to submit a patch including this fix:
Quoted 4 lines
https://github.com/git-for-windows/git/commit/4694320330e1b4d9178e13e215ce60a1cc8e0b1c
(The idea of the
fixup!was to make this change part of a larger change during the next merging rebase of Git for Windows.)
Thanks. Is that an Ack?
Signature · 18 lines
-- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "Git for Windows" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
Hi Junio,
Quoted 21 lines · Junio C Hamano
Quoted 19 lines · Johannes Schindelin
Quoted 6 lines · Johannes Sixt
t/t2019-checkout-ambiguous-ref.sh +0
-0t/t2019-checkout-ambiguous-ref.sh test_expect_success 'wildcard ambiguation, paths win' ' · line 75
Quoted 8 lines
t/t2019-checkout-ambiguous-ref.sh +1
-1@@ -69,7 +69,7 @@ test_expect_success 'wildcard ambiguation, paths win' ' ) ' -test_expect_success 'wildcard ambiguation, refs lose' ' +test_expect_success !MINGW 'wildcard ambiguation, refs lose' ' git init ambi2 && ( cd ambi2 &&FWIW I planned to submit a patch including this fix:
Quoted 6 lines
Quoted 4 lines
https://github.com/git-for-windows/git/commit/4694320330e1b4d9178e13e215ce60a1cc8e0b1c
(The idea of the
fixup!was to make this change part of a larger change during the next merging rebase of Git for Windows.)Thanks. Is that an Ack?
Yes, this is an Ack. (Although I would have preferred to organize the contribution of Windows-related patches better, really.)
Ciao,
Dscho
Signature · 18 lines
-- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "Git for Windows" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.