Skip to contentSkip to conversation

wildmatch test: remove redundant duplicate test

PATCH In review Ævar Arnfjörð Bjarmason 2 participants 3 messages May 27, 2017 – May 29, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wildmatch test: remove redundant duplicate test

Remove a test line that's exactly the same as the preceding line.

This was brought in in commit feabcc173b ("Integrate wildmatch to git", 2012-10-15), these tests are originally copied from rsync.git, but the duplicate line was never present there, so must have just snuck in during integration with git by accident.

---
 t/t3070-wildmatch.sh | 1 -
 1 file changed, 1 deletion(-)
t/t3070-wildmatch.sh +0 -1
index ef509df351..7ca69f4bed 100755
@@ -135,7 +135,6 @@ match 1 x '5' '[[:xdigit:]]'
 match 1 x 'f' '[[:xdigit:]]'
 match 1 x 'D' '[[:xdigit:]]'
 match 1 x '_' '[[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:graph:][:lower:][:print:][:punct:][:space:][:upper:][:xdigit:]]'
-match 1 x '_' '[[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:graph:][:lower:][:print:][:punct:][:space:][:upper:][:xdigit:]]'
 match 1 x '.' '[^[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:lower:][:space:][:upper:][:xdigit:]]'
 match 1 x '5' '[a-c[:digit:]x-z]'
 match 1 x 'b' '[a-c[:digit:]x-z]'
Signature · 1 line
2.13.0.303.g4ebf302169
#1 lore raw

Thanks. Did you run "sort | uniq -c" on it or something ;-)?

Will apply.

#2 lore raw
Quoted 1 line · Junio C Hamano

Thanks. Did you run "sort | uniq -c" on it or something ;-)?

I've been writing a new backend for wildmatch(). Was wondering what the difference in these two failing tests was, turns out there was none.

Quoted 1 line

Will apply.

Thanks.